XylusChen / pe

0 stars 0 forks source link

Undo does not undo creation of backups #13

Open XylusChen opened 1 year ago

XylusChen commented 1 year ago

To replicate:

backup 1

undo

Backup at slot 1 still exists.

soc-pe-bot commented 1 year ago

Team's Response

Thank you for raising this issue, however, in the Enhancement section of our Developer Guide, we have stated that the 'undo' command currently only has the ability to undo modifications made to the person information.

Screenshot 2023-04-15 at 1.52.33 PM.png

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

description for undo command not clear

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


Undo command can't undo commands like find, list and view. But it's not specified in the UG.

image.png


[original: nus-cs2103-AY2223S2/pe-interim#1389] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for bringing up this matter. We appreciate your valuable input and would like to address your concerns in detail. We acknowledge that it is a valid point that we could mention this information in our User Guide, similar to what we have done in our Developer Guide. However, we did not include it in our User Guide because our short prompt indicated that the previous change was a mistake, and the commands you mentioned, such as 'list', 'view', or 'find', do not modify the current user data. We assumed that the readers of the User Guide would have the necessary expertise to understand this point.

We understand that you may have interpreted the lack of this information as a documentation bug. However, we do not see it as such. We do believe that adding this information to the User Guide would enhance its overall value and be a valuable addition. We appreciate your suggestion and will certainly consider it for future updates to our documentation.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]