Xyness / SimpleClaimSystem

Minecraft plugin, claim system for servers
https://www.spigotmc.org/resources/simpleclaimsystem-%E2%9C%85-1-18-1-21-fully-configurable-%E2%9A%99%EF%B8%8F-folia-supported-%E2%9A%A1.115568/
Other
15 stars 4 forks source link

BUG: reload and config-reload commands overwrite config.yml #10

Closed mauvehed closed 2 months ago

mauvehed commented 2 months ago

Versions: MineCraft v1.21.1 SCS v1.11.5.2 via Spigot

Problem: Whenever I use /scs reload or scs config-reload it completely wipes out my config.txt and I lose all my settings.

Expectation: I would not expect either command to wipe and replace my config. Only to reload the plugin, including my existing config file.

Logs:

/scs config-reload

[Sun 14:05:30 INFO ] Config reload attempt.. Please wait. [Sun 14:05:30 INFO ] You can continue what you were doing. [Sun 14:05:30 INFO ] ========================================================================== [Sun 14:05:30 INFO com.zaxxer.hikari.HikariDataSource] SQLitePool - Starting... [Sun 14:05:30 INFO com.zaxxer.hikari.HikariDataSource] SQLitePool - Start completed. [Sun 14:05:30 INFO ] ========================================================================== [Sun 14:05:30 INFO ] Config reload completed. [Sun 14:10:00 INFO Server] Saving the game (this may take a moment!) [Sun 14:10:00 INFO Server] Saved the game `

/scs reload

[Sun 14:01:22 INFO ] Reload attempt.. Please wait. [Sun 14:01:22 INFO ] You can continue what you were doing. [Sun 14:01:22 INFO ] ========================================================================== [Sun 14:01:22 INFO com.zaxxer.hikari.HikariDataSource] SQLitePool - Starting... [Sun 14:01:22 INFO com.zaxxer.hikari.HikariDataSource] SQLitePool - Start completed. [Sun 14:01:22 INFO ] Loading claims.. [Sun 14:01:24 INFO ] 8/8 claims loaded. [Sun 14:01:24 INFO ] > including 2 protected areas. [Sun 14:01:24 INFO ] Loading players.. [Sun 14:01:24 INFO ] 3 players loaded. [Sun 14:01:24 INFO ] ========================================================================== [Sun 14:01:24 INFO ] Reload completed. [Sun 14:05:00 INFO Server] Saving the game (this may take a moment!) [Sun 14:05:00 INFO Server] Saved the game

mauvehed commented 2 months ago

This looks to have been a false positive. I removed my SCS folder and started fresh, and it became obvious that the new default config had a lot more comments and clarity than whatever config I had setup. I think I screwed up my config in some manner and it was causing this problem and possibly others!

The good thing is that I could copy back over my storage.db and keep all my player claims!