Xyphyn / photon

An opinionated web client for Lemmy to help users discover the fediverse.
https://phtn.app
GNU Affero General Public License v3.0
392 stars 43 forks source link

Deleted/removed comments are still shown #279

Closed Tywele closed 9 months ago

Tywele commented 9 months ago

Describe the bug Deleted or removed comments are still shown under a post with a red trash icon beside the comment header

To Reproduce (if applicable) See here for an example https://lemmy.dbzer0.com/comment/8749884

Expected behavior I expect to not see deleted/removed comments.

Screenshots Screenshot of the link above in Photon

Versions

BrikoX commented 9 months ago

It's a configurable setting in Photon. See image

Tywele commented 9 months ago

They are turned on for me grafik

And if I understand the option correctly this option is only for posts and not comments anyway.

BrikoX commented 9 months ago

Sorry for the confusion, my bad.

I was able to reproduce on v1.26.0.

From my limited understanding, it's the intended behavior to just add the icon instead of hiding it. https://github.com/Xyphyn/photon/blob/08fcf185734d749585033619780e385118d19b1a/src/lib/components/lemmy/comment/Comment.svelte#L130-L138

Tywele commented 9 months ago

This should definitely be an option wether you want to still see deleted/removed comments or not. Just like for posts.

Xyphyn commented 9 months ago

i forgot this option still existed and while cleaning code i accidentally removed this. re-adding right now

Xyphyn commented 9 months ago

Would you like deleted/removed comments to have the child comments hidden as well?

Tywele commented 8 months ago

No child comments should still be visible

Edit: Or maybe that could be an additional option.

poVoq commented 8 months ago

There is either a regression on this in the current version (1.28.4), or this is still broken.

It is especially odd that comments that a moderator deleted get still shown to everyone, even not logged in users. The only way to tell is that red wastebin icon next to the post.