Added home, settings and explore menu entries back into sidebar

[Tywele]

I think the new navigation layout is too different from the old layout and messes up muscle memory and the frontpage button is also too far away and leads to too much mouse movement for a button that is regularly used.

I have moved the frontpage, settings, and explore buttons back to the sidebar for easier access and kept everything else as is.

[vercel[bot]]

@Tywele is attempting to deploy a commit to the Xylight's projects Team on Vercel.

A member of the Team first needs to authorize it.

[sevonj]

I'm not sure what kind of plan Xylight has for the sidebar, but I agree on having all fundamental navigation there.

Screenshot of this pr change


There are more things that could be changed in the sidebar. I'm not sure if they're all good ideas, but I'll just throw them here anyway.

• I use the All/Subscribed buttons in voyager a lot. Maybe we could do that?
  • A more radical option would be to move all the location items here. It would free up some precious horizontal space; my phone is too narrow to show the view selectbox.
    • Actually, the sidebar or subbed communities even accessible on narrow screens?
• Move settings down. Now they are roughly categorized to a "browsing group" and an "account/settings group".

vger


Something like this?

[Xyphyn]

The issue with this is that it removes location cohesion. Currently, the sidebar is associated with everything related to your account. (Profile, inbox, saved, account switcher, communities), and the navbar is associated with navigation to common pages. If I were to add these into the sidebar, I'd probably have to commit hard and completely remove the regular navbar, but this would ruin people's muscle memory.

[Tywele]

To be fair with the change to the navbar you've already ruined people's muscle memory once. You also used to have an option for legacy navigation layout which would be perfect for this as this is the real legacy navigation that Photon once had. With a bit of tinkering I could implement it as an option. Maybe I would need some assistance as this pull request is the first time ever I've dealt with Svelte.

[Xyphyn]

The legacy navigation layout still exists? You just set both panel mode and position to "adaptive"

[Tywele]

But that doesn't bring back the menu entries in the sidebar. That's the point. Even with both set to adaptive my muscle memory (and probably lot's of other people's) is completely useless with any version past 1.28

[Tywele]

The option for this could be called "Legacy Sidebar" or something.

[Tywele]

I added a setting for the legacy sidebar navigation:

The setting also disables the "Settings" menu entry when you are not logged in since with the setting enabled you would've duplicate menu entries of "Settings".

The setting can also be set via an ENV and is set to false by default.

[Xyphyn]

What if I added completely custom pins?

[Tywele]

That's an interesting idea that I would like to spin a bit further: Since every menu entry in the sidebar is accessible some other way anyway (mainly through the Profile Picture menu in the top right). You could take this concept and make a setting to select which menu entries in the sidebar are shown (and in which order) instead of pins that are on top of it. The default could either be the layout it is right now or the sidebar would only contain Favorites, Moderates and Subscribed.

What do you think of that?

I would also take a shot at it if you don't want to invest the time in it.

[Xyphyn]

The pins system is easier to code, but I could try that.