Xyphyn / photon

A replacement for lemmy-ui with more features, a better design, and more customizability.
https://phtn.app
GNU Affero General Public License v3.0
349 stars 39 forks source link

In Sort drop down menu, when Comments are selected, it shows posts instead #420

Closed 4lk closed 1 week ago

4lk commented 1 week ago

Describe the bug In the Frontpage, when I go to the second drop down menu named Sort, if I select Comments or New Replies I see posts instead. No matter which Location is chosen (All, Local, Subscription, Moderator) or which View (Cozy, List, Compact, Legacy)

To Reproduce Steps to reproduce the behavior:

  1. Go to the Frontpage
  2. Click on the Sort drop down menu on the top left
  3. Scroll down to Comments or New Replies and select one of them
  4. See posts appearing bellow, instead of comments

Expected behavior I would expect to see comments. At least in the Moderator view, to help moderation.

Screenshots NoComents

Versions

4lk commented 1 week ago

This is not a bug after all. I just realized that when Comments is selected we see posts with most comments and when New Replies is selected we see posts with the newest replies.

Should I close it?

sevonj commented 1 week ago

I translated this line into "most comments". Maybe that would work better in English, too.

Xyphyn commented 1 week ago

This isn't necessarily a bug. For clarity's sake, I renamed "Comments" to "Most Comments" in the English translation.

sevonj commented 1 week ago

@4lk I think this can be closed now.

https://github.com/Xyphyn/photon/commit/f0134dbbcfa6237ef1ab341b778029646bc295fa