search

XyrisOS / xyris

The Xyris Kernel
https://xyr.is
MIT License
154 stars 11 forks source link

Cleanup `#include` Syntax #294

Closed Kfeavel closed 2 years ago

Kfeavel commented 3 years ago

Headers should use quotes (#include "header.hpp") when the header file is in the same directory. Only when it lives elsewhere in the kernel should angled brackets (#include </path/to/header.hpp>) be used.

Kfeavel commented 3 years ago

Leaving this issue open since it's a fact that includes need to be cleaned up, but @micahswitzer raises a fair point that angled brackets are supposed to be for public includes and quotes are supposed to be for private includes.

Hold off on this until we have a clean definition of what is public and private.

Kfeavel commented 2 years ago

Going to take a queue from SerenityOS and others and keep the angled include brackets. Closing.