search

Xzandro / sw-exporter

This tool will parse intercepted data from Summoners War and extract information on the monsters and runes of the user.
Apache License 2.0
412 stars 193 forks source link

Logs UI Improvement #424

Closed FabulousCupcake closed 2 years ago

FabulousCupcake commented 2 years ago

Updates Logs page to look slightly better and fully utilize semantic-ui's <Label> features.

Before Screen Shot 2021-11-07 at 23 08 04
After Screen Shot 2021-11-07 at 23 07 41
Xzandro commented 2 years ago

Thanks for the PR. This looks good to me. Could you maybe provide examples for warnings and errors as well?

FabulousCupcake commented 2 years ago
Screen Shot 2021-11-08 at 00 44 08 Screen Shot 2021-11-08 at 00 45 47
Xzandro commented 2 years ago

I personally liked it more with the divider added between the log entries. Currently it looks a bit noisy without it present. Would you mind adding that back? Otherwise this looks fine.

FabulousCupcake commented 2 years ago

IMO it's perfectly readable now that the colored label is longer (it helps to discern visually the separation between feed items), but maybe that's just me.