search

Xzandro / sw-exporter

This tool will parse intercepted data from Summoners War and extract information on the monsters and runes of the user.
Apache License 2.0
412 stars 193 forks source link

Adding Darkmode, M1 setup guide, Reappraisal efficiency preview & lib updates #454

Closed EytanMorg closed 1 year ago

EytanMorg commented 2 years ago

Patch summary:

Xzandro commented 2 years ago

Hi, thanks for the PR.

I do not have anything against the guide section updates. This is always welcome. However I have a few issues with the dark mode: first off, I'm not a designer by any means, but when I look at it, it doesn't look right. I think the contrast between the font color and the background might be too high. Pretty much anywhere if there is white on dark (checkboxes, input fields & font) it's a bit draining on the eyes I guess. Not sure if there is an easy fix for that. I could ask my web designer buddy what he thinks, but he is very busy currently. I think vuetify does a very good job in that regard (a material design framework I work a lot with). https://vuetifyjs.com/en/components/text-fields/ (can toggle dark/light mode on the page)

We also might make it so, that the setting if dark mode or not persist and that its an actual setting in SWEX.

Ultimately not complete deal breakers, but maybe you are motivated to look into that a little bit more.

EytanMorg commented 1 year ago

PR has been spit up in: