search

Xzandro / sw-exporter

This tool will parse intercepted data from Summoners War and extract information on the monsters and runes of the user.
Apache License 2.0
412 stars 193 forks source link

Added new rune efficiency setting #493

Open Foolishmetal opened 1 year ago

Foolishmetal commented 1 year ago

Added a new setting that calculates rune efficiency based on SWOP's updated formula.

Xzandro commented 1 year ago

We already talked about this in Discord, but just so I do not forget.

Personally, I would do the manipulation of the substats directly in the rune-efficiency plugin code (if the new SWOP efficiency setting is enabled of course) and then send that to the function to keep the function clean and without side effects. Remove getRuneEfficiencySWOP, add a new setting to the existing rune-efficiency plugin, if that setting is enabled manipulate the rune props before sending it to the function. This way, you have minimal code adjustments, can use an easily accessible settings and no duplicate code.

Xzandro commented 10 months ago

Is this still being worked on?