Xzensi / NipahTV

✨ NipahTV - A Better Kick and 7TV Emote Extension for Kick ✨
https://nipahtv.com
7 stars 2 forks source link

Lines taking up too much space & emotes too large - option to keep native setting? #174

Closed pwnflakes closed 3 weeks ago

pwnflakes commented 1 month ago

Hey,

Thanks for making this project, stumbled across it when looking for kick stuff and chatbots a while before 7TV broke. Currently for me the size of emotes and lines is just a bit too chunky and there's no setting to change it from what I can find, a setting to just keep native sizes + spacing would be good, although I imagine in future text size or line height may be a setting.

Left is native, right is with Nipah. Some might prefer it how it is now but I definitely prefer fitting a few more messages on screen and having native sized emotes. Also glad to see there's a toggle to use the native quick emote bar, used to that now!

image

Thanks again for working on this!

Xzensi commented 1 month ago

You are completely right to notice this, because this was indeed an issue! It was caused due to a necessary restructuring of all emote UI stuff where it didn't correctly apply max sizes anymore to the emotes in chat, sorry about that!

This was fixed in 1.5.37.

That being said, it's true that the emotes are a tiny bit bigger (about 1.5 pixels) than 7tv. Please do let me know if you still consider the emotes too big on 1.5.37.

Xzensi commented 3 weeks ago

Closing due to inactivity. As mentioned if you still consider the message line and emote spacing too big, feel free to re-open ticket and let me know.

pwnflakes commented 3 weeks ago

@Xzensi Sorry for the delay, completely native is what I'd want ideally, I often make the size smaller than default in most places but default is okay. Within the Settings cog, Chat Appearance, there's the slider for Font Size which has a Default size, 1 smaller size, and 2 larger sizes. This setting seems to affect emote size too, if the extension kind of just looked at what the user had for that and had the font+emote sizes respecting that setting it'd be great but I don't know how compatible that is with what you've already done. Can't reopen

Xzensi commented 2 weeks ago

I get it, I definitely have been wanting to add more of such settings but just haven't gotten to it yet. Eitherway thank you for the feedback, it helps priortizing what people want.

It is important to note however that by default it'll never be as compact as native Kick messages, because for one, Kick emotes are 24px while 7TV emotes are 32px. I've opted for 32px as default and will upscale all smaller emotes accordingly. Secondly, Kick does not equalize message lines lineheight, meaning it'll be more compact but ugly with variating lineheights due to this.

Instead, NTV now is much closer to what is normative on Twitch, than what Kick does.

Xzensi commented 2 weeks ago

Added settings options to change message font size and emote size & spacing in. Defaults have also been updated to match native Kick message styling better in 1.5.48

I do think I'll be changing it back from 28px to 32px later when expanding to other platforms, but I'll leave it to match Kick's 28px for now.

pwnflakes commented 1 week ago

That works great to be honest it looks a lot better. I did wonder why Kick's emotes look like they had to be so much more zoomed in (on face emotes etc) to show any detail, but yeah I'd agree with changing entirely to 32px even on the kick Native if it's possible to nicely have the spacing between lines quite compact. It definitely looks smaller now than when I raised this issue, but is 32px what it was at that point or was it bigger? I checked Twitch and I have default FFZ font size (13) and within the Chat Appearance slider I do have it all the way to the Left to make it a little smaller, so may be biased towards a smaller size anyway. If there's settings for this stuff it solves everything for everyone either way so all good!

Xzensi commented 1 week ago

Back then it was indeed 32px, but native Kick is 28px so I changed defaults to match it. When the emotes are 32px the lines will be much taller and it'll a lot less compact as it was before so it's not possible to have it 32px and compact, but there's settings to customize all of it so you can just set it to whatever you want anyway now.