search

XzzX / mrmd

Multi Resolution Molecular Dynamics
Apache License 2.0
1 stars 2 forks source link

cmake: don't use kokkos directly #1

Closed junghans closed 3 years ago

junghans commented 3 years ago

Unless you have a good reason for it, there is really no need to link kokkos directly the cabana target will take care of that.

XzzX commented 3 years ago

I know Kokkos is a public dependency of Cabana. But I like the "include what you use" philosophy and I use Kokkos functions directly. Besides Cmake should remove duplicates.

junghans commented 3 years ago

I know Kokkos is a public dependency of Cabana. But I like the "include what you use" philosophy and I use Kokkos functions directly. Besides Cmake should remove duplicates.

Makes sense! It can lead to the situation that cmake finds two different versions of kokkos as Cabana remember where its kokkos was located. Not so much in your case as are using Cabana as a git submodule and not through find_package(Cabana).