Y3Z0N / ImmersiveFX

IFX is a fork of Dynamic Surroundings which aims to add more sound events, particles and also replaces every single sound from DS and a few from MC.
GNU General Public License v3.0
6 stars 5 forks source link

Settings don't load properly on entering world. #5

Open SteaSteaStea opened 2 years ago

SteaSteaStea commented 2 years ago

Whenever I open my world I have to open the in-game configuration menu and click "done" in order for the settings to be re-applied (all the lowered sounds etc.) The changes I've made get saved in the config but they don't get applied unless I confirm it by opening and properly closing the menu. Any idea what could be happening there? It was a bug even in the original mod on 1.16.5. I'm using Enigmatica6 + a few additional mods.

Y3Z0N commented 2 years ago

I need more derailes. i could not reproduce your issue

SteaSteaStea commented 2 years ago

Here's the full modlist: https://pastebin.com/raw/PdDEP5T9

It seems to be some kind of mod conflict though It's rather hard to troubleshoot this since it happens on load - not during some specific mod related action.

To reproduce it simply change the volume of something (footsteps/fire/etc.) - save and exit and reopen the game. Now the sounds should be back to default (unchanged settings). Simply opening the config menu and clicking done changes it back to the configured values.

Y3Z0N commented 2 years ago

Could not reproduce this issue looks like a conflict. I‘ll let this report open and do some research with the modlist

SteaSteaStea commented 2 years ago

I noticed the same bug occurring even on my test instance with very few mods so this should at least help with finding the conflicting mod. It's got to be caused by one of these: MultiMC_9yGkFu5UId

SteaSteaStea commented 2 years ago

I ended up removing the mods one by one and ended up still having the issue even with ImmersiveFX only. I'll try deleting the configs and stuff perhaps there's something going on there.

EDIT: Turns out the issue still persists even after deleting all configs: ImmersiveFX+1.0.2+1.16.5 Forge 36.2.34 jre1.8.0_333

Steps to reproduce: Open a world, move into a forest biome, and hear the forest ambiance (bird sounds). Open the GUI, lower the sound of something to 0 (in this case the forest birds sound), click done. Now the selected sound stops playing. Restart the game, open the world. The sound which you previously disabled start playing. In the GUI the settings are saved properly (selected sound volume set to 0), however the settings are not applied to the game unless you open the GUI and click done.

gaffougasse commented 2 years ago

I'm having exactly the same issue. My mod list seems to be irrelevant as it still happens even with only this mod. This isn't that big of a deal as you can fix the issue by opening the GUI and click done each time you play, but it would of course be better not having to.

ImmersiveFX+1.0.2+1.16.5 Forge 36.2.0