Open GoogleCodeExporter opened 8 years ago
Forgot to mention that I see the same error in Safari, but Firefox 19 on same
machine works fine.
Original comment by swri...@whatsupinteractive.com
on 8 Mar 2013 at 3:24
Thanks for your report.
I can only test in Windows and Linux at the moment. Could you please check the
javascript console on Safari and see if any error is shown?
Original comment by i...@subwaydesign.com.ar
on 8 Mar 2013 at 6:36
I checked in Google chrome console (just not as familiar with Safari).
The problem was that the a lot of the calls to fonts and js includes were being
blocked.
-- NOTE -- I am running under HTTPS
The calls were to http sites which are blocked under the default security
settings of Chrome.
I switched the calls to https calls and the google stuff was fine, but the
jquery call 404'd. I created a local copy of the jquery file and now everything
seems to be working.
Original comment by swri...@whatsupinteractive.com
on 8 Mar 2013 at 8:16
This is very interesting, especially considering that those scripts are loaded
from Google's own CDN. Seems like using a local copy of jQuery will be the best
approach.
Original comment by i...@subwaydesign.com.ar
on 11 Mar 2013 at 9:45
I actually changed the jquery call to google's jquery which is available.
Everything works great now.
Would you like me to submit a patch for the switch?
There are just a few places in the code that need to be changed. I would check
for HTTPS at the beginning of the page (or an include that is already included
in all pages) and set a constant. Then any call to an external asset would be
prefaced by that constant.
Original comment by swri...@whatsupinteractive.com
on 11 Mar 2013 at 11:05
Here are the changes I made. If I commit access I would, since I do not, I'm
attaching them.
sys.includes.php
added line 10: define('PROTOCOL', empty($_SERVER['HTTPS'])? 'http' : 'https');
header.php:
changed line 44: <script type="text/javascript" src="<?php echo PROTOCOL; ?>//ajax.googleapis.com/ajax/libs/jquery/1.8.3/jquery.min.js"></script>
changed line 53: <link href='<?php echo PROTOCOL; ?>://fonts.googleapis.com/css?family=Open+Sans:400,700,300' rel='stylesheet' type='text/css'>
changed line 54: <link href='<?php echo PROTOCOL; ?>://fonts.googleapis.com/css?family=Abel' rel='stylesheet' type='text/css'>
header-unlogged.php
Exact same changes as header.php except line numbers are 41, 48, & 49
install/index.php:
Exact same changes as header.php except line numbers are 57, 67, & 68
Original comment by swri...@whatsupinteractive.com
on 11 Mar 2013 at 11:55
Attachments:
Thank you!! May I add you email in the source code?
Original comment by i...@subwaydesign.com.ar
on 12 Mar 2013 at 6:50
I really don't think of this as a significant contribution worthy of named
credit.
Thanks for the work you do on this app - I find it very useful
Already found a bug line the jquery line is missing a colon before the double
slash
Original comment by swri...@whatsupinteractive.com
on 12 Mar 2013 at 11:42
Yes, I found that and fixed it before commiting.
Every contribution is important. We all make ProjectSend together.
Let me know if you want your mail or name (what is it by the way?) mentioned, I
would like to do it.
Original comment by i...@subwaydesign.com.ar
on 12 Mar 2013 at 9:55
That's generous to include me.
My name is Scott Wright and my email is swright at whatsupinteractive dot com
Original comment by jswright61@gmail.com
on 13 Mar 2013 at 12:28
:D
One question please. Do you use Safari on Mac?
I have a lot of users reporting a problem with the jquery script that handles
the files extensions on the options page. Since the script gives an error, the
page is useless do to the tabs scripts not loading.
Please let me know if you have this problem. I do not have a Mac to test this
and since the error doesn't ocurr on Windows I cannot find a solution.
Thanks again!!
Original comment by i...@subwaydesign.com.ar
on 16 Mar 2013 at 9:37
I was busy with a home improvement project this weekend. I will look into this
this week and let you know what I find.
-Scott
Original comment by swri...@whatsupinteractive.com
on 18 Mar 2013 at 1:04
I have the same problem, and I want to add some details
1. When I configure in the option.php the system URL https://baseurl/
everything is normal like the picture 1, but occurs this problem.
2. If I left in the option.php the system URL http://baseurl/ and on my browser
I write https://baseurl/ the website looks worse like picture 2.
I think, you can make an option too force the system to use https without this
problems. For example LimeSurvey and moodle have this kind of configuration.
P.S.1 I already tried with modified and replace those files like said
swri...@whatsupinteractive.com, but it didn't works.
P.S.2 This project is great to my work, but without https my clients don't want
to use it. Anyway you deserve a donation :)
Original comment by markhuizar
on 10 Apr 2013 at 2:13
Attachments:
Thanks for your report!
I made a few changes (as suggested by a user) that should help support https on
your server.
I couldn't upload the new version yet but it will be released this week.
Please keep an eye for it and let me work how it works for you :)
I'm glad the project is of use to you! :D
Thanks!
Original comment by i...@subwaydesign.com.ar
on 10 Apr 2013 at 4:35
Hi, don't know whether it is fixed already but I tried using the files sent by
Scott and changed one line inside the Header.php to get it working on my
Installation (r412):
from:
<script type="text/javascript" src="<?php echo PROTOCOL;
?>//ajax.googleapis.com/ajax/libs/jquery/1.8.3/jquery.min.js"></script>
to:
<script type="text/javascript" src="<?php echo PROTOCOL;
?>://ajax.googleapis.com/ajax/libs/jquery/1.8.3/jquery.min.js"></script>
now i can use it with https as well.
rgds Mario
Original comment by mr120...@gmail.com
on 7 May 2013 at 7:50
If you copy the header.php lines on comment #6 you have to remember to add the
colon on line 44 just before: "//ajax.googleapis..." to get it working.
It also works for version r375.
Original comment by georgesj...@lespointscom.com
on 2 Sep 2013 at 12:38
Whilst not exactly related to this fault I am getting a message
"Only Secure Content is displayed" from Internet Explorer on the login screen
I am running version r561 as looking at the translated source for the login I
find
<link href='http://fonts.googleapis.com/css?family=Open+Sans:400,700,300'
rel='stylesheet' type='text/css'>
<link href='http://fonts.googleapis.com/css?family=Abel' rel='stylesheet'
type='text/css'>
I am running under SSL so the http should be https
I did apply the changes to r412 and that was working OK
I presumed r561 had the changes incorporated.
As I am always running under SSL I changed the
define('PROTOCOL', empty($_SERVER['HTTPS'])? 'http' : 'https');
to
define('PROTOCOL', 'https');
Now working fine without that message.
But this is not a true solution
Alan
Original comment by AlanReib...@googlemail.com
on 2 Apr 2015 at 1:30
Original issue reported on code.google.com by
swri...@whatsupinteractive.com
on 8 Mar 2013 at 3:23