search

YAMJ / yamj-v2

Yet Another Movie Jukebox (YAMJ) v2
GNU General Public License v3.0
28 stars 11 forks source link

HDDVDs are identified incorrectly in <videoSouce> tag in xml. #1640

Closed Omertron closed 9 years ago

Omertron commented 9 years ago

Original issue 1641 created by Omertron on 2010-10-12T18:38:19.000Z:

When scanning a video identified in the folder name as HDDVD but it is in BDMV folders, the <videoSource> tag in the xml incorrectly specifies '1080p 24Hz'.

What steps will reproduce the problem?

  1. Have a BDMV folder structure.
  2. Place inside a folder indicating HDDVD source (eg 'A Clockwork Orange (1971).HDDVD') but any name with HDDVD on the end reproduces this.
  3. Scan and the <videoSource> tag in the xml for the movie will be incorrect.

What is the expected output? What do you see instead? expected: <videoSource>HDDVD</videoSource> What it does: <videoSource>1080p 24Hz</videoSource>

What version of YAMJ are you using? On what operating system? yamj-svn-r1847 on Windows XP 32bit

What device are you using YAMJ on? Networked Media Tank, PlayonHD, Other? PCH C-200

Please provide any additional information below. I use UBG18 covers and there is a switch for red disc for HDDVD and blue disc for BluRay. UBG looks for HDDVD in the videosource tag and as it does not have that and it is a BDMV folder it assumes it is a BD. So all my HDDVDs are identified as BDs. There is a bug in UBG too (told MrM about it) but even fixing the UBG bug will not make it work due to invalid video source in the xml.

Omertron commented 9 years ago

Comment #1 originally posted by Omertron on 2010-10-14T08:09:39.000Z:

This issue was closed by revision r1855.

Omertron commented 9 years ago

Comment #2 originally posted by Omertron on 2010-10-14T21:56:20.000Z:

This is only partially fixed. It is fixed for single films however, if you have a set of HDDVDs then the set and films contained in the film still has the invalid <videoSource) tag in their XML files.

Examples are The Matrix Trilogy set. All 3 films and the set_ xml files are still incorrect.

Omertron commented 9 years ago

Comment #3 originally posted by Omertron on 2010-10-15T05:41:17.000Z:

Are all three films HDDVD BluRays?

Omertron commented 9 years ago

Comment #4 originally posted by Omertron on 2010-10-15T08:41:17.000Z:

All 3 are HD DVDs ripped to BDMV folders and put in a set called 'The Matrix Trilogy'.

The Matrix (1999).HDDVD The Matrix Reloaded (2003).HDDVD The Matrix Revolutions (2003).HDDVD

and an example from the .nfo for the matrix:

<sets>
  <set order="1">The Matrix Trilogy</set>
</sets>

I have a few sets like this, mission impossible set, Fast & furious etc.

Each film and the Set_The Matrix Trilogy_1.xml xml's file have 1080P 24hz in them.

Omertron commented 9 years ago

Comment #5 originally posted by Omertron on 2010-10-15T08:48:39.000Z:

Re-checking my nfo files, it seems I have a videoSource override set in the matrix set..... Will report back shortly.

Omertron commented 9 years ago

Comment #6 originally posted by Omertron on 2010-10-15T10:52:30.000Z:

OK, finished testing and it does work OK. Was an nfo problem at my end.

Omertron commented 9 years ago

Comment #7 originally posted by Omertron on 2010-10-15T11:11:51.000Z:

<empty>