YAMJ / yamj-v2

Yet Another Movie Jukebox (YAMJ) v2
GNU General Public License v3.0
28 stars 11 forks source link

Cast enhancement #1896

Closed Omertron closed 9 years ago

Omertron commented 9 years ago

Original issue 1897 created by Omertron on 2011-04-25T22:11:26.000Z:

What device are you using YAMJ on? PHP-110

Hi,

It would be nice to have cast member as a link that points to cast member page with an image, short info and Filmography.

The cast member page should be shared between all movies

10x

Avi

Omertron commented 9 years ago

Comment #1 originally posted by Omertron on 2011-05-03T11:53:14.000Z:

Example of data format on attach

Omertron commented 9 years ago

Comment #2 originally posted by Omertron on 2011-05-03T12:07:41.000Z:

is this feature is going to be added?

Omertron commented 9 years ago

Comment #3 originally posted by Omertron on 2011-05-03T13:55:54.000Z:

Ilgizar, Please use the model from TheMovieDb as this has cast information already in it and would be a good start.

The data model can be seen here: http://code.google.com/p/themoviedbapi/source/browse/#svn%2Ftrunk%2Fthemoviedbapi%2Fsrc%2Fmain%2Fjava%2Fcom%2Fmoviejukebox%2Fthemoviedb%2Fmodel

If you need access to the source, let me know.

Omertron commented 9 years ago

Comment #4 originally posted by Omertron on 2011-05-03T16:08:26.000Z:

TheMovieDb have a nice structure: more thought. I use it, but need sequence of ID, as it release on YAMJ:

XXX YYY ZZZ

if this is possible.

Omertron commented 9 years ago

Comment #5 originally posted by Omertron on 2011-05-03T18:31:32.000Z:

Сompilation is successful, but the scanner fails. I do not want to poison the repository, so the attached files with the changes. Crux of the problem in the double type definition artwork on com.moviejukebox.model and com.moviejukebox.themoviedb.model. My changes:

  1. add to class Movie Collection people = new ArrayList();
  2. add to class Library private TreeMap<String, Person> people = new TreeMap<String, Person>();
  3. add to function writeMovie on class MovieJukeboxXMLWriter procedure writes of personal data (begin from line 1310)
Omertron commented 9 years ago

Comment #6 originally posted by Omertron on 2011-05-03T18:48:25.000Z:

Ok, so it might be best to copy that model into MJB to prevent this issue. That way we can tweak it to meet our requirements.

Omertron commented 9 years ago

Comment #7 originally posted by Omertron on 2011-05-05T17:13:36.000Z:

attached real example file: first is movie xml file, second - person. also downloaded photo per person.

Omertron commented 9 years ago

Comment #8 originally posted by Omertron on 2011-05-05T17:24:36.000Z:

Why are you replicating both the cast and the person sections? That'll make the XML quite large for films.

We should keep with the split that we have at the moment (cast/writer/director), although I agree that a "person" node would be better eventually.

Omertron commented 9 years ago

Comment #9 originally posted by Omertron on 2011-05-05T17:36:50.000Z:

I also get this compilation error:

[INFO] ------------------------------------------------------------- [ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] \Eclipse\moviejukebox\yamj\src\main\java\com\moviejukebox\plugin\TheMovieDbPlugin.java:[40,7] com.moviejukebox.plugin.TheMovieDbPlugin is not abstract and does not override abstract method scan(com.moviejukebox.model.Person) in com.moviejukebox.plugin.MovieDatabasePlugin [INFO] 1 error

Omertron commented 9 years ago

Comment #10 originally posted by Omertron on 2011-05-05T17:39:01.000Z:

Oh, and we need to add an option to turn this off if you don't need it. mjb.personInfo=false or something

Omertron commented 9 years ago

Comment #11 originally posted by Omertron on 2011-05-05T19:02:17.000Z:

This issue was updated by revision r2340.

Fix compilation error with TheMovieDbPlugin

Omertron commented 9 years ago

Comment #12 originally posted by Omertron on 2011-05-06T02:59:36.000Z:

new options: mjb.people= - toggle cast enhancement (def: false) mjb.people.maxCount= - count of person from per movie to scan personal details (def: 10) photo.scanner.photoExtensions= - image extensions (def: jpg,jpeg,gif,bmp,png) mjb.forcePhotoOverwrite= - toggle image overwrite (def: false) plugin.biography.maxlength= - max length of biography (def: 500) plugin.filmography.max= - count of movie per person (def: 20)

Omertron commented 9 years ago

Comment #13 originally posted by Omertron on 2011-05-06T03:43:14.000Z:

Does it work when the default plugin is Allocine?

Omertron commented 9 years ago

Comment #14 originally posted by Omertron on 2011-05-06T04:21:18.000Z:

scanner people are made ​​only for imdb

Omertron commented 9 years ago

Comment #15 originally posted by Omertron on 2011-05-06T10:37:45.000Z:

fixed list of alternate name, character on person information, append director and writer to person list. I replicating both the cast and the person sections, because backward compatibility with the current skins. new option: plugin.people.maxCount= - count of actor per movie (def: 10)

Omertron commented 9 years ago

Comment #16 originally posted by Omertron on 2011-05-06T17:33:02.000Z:

This issue was updated by revision r2346.

append HTML transformation new option: mjb.view.personList= - comma-separated list of xsl files (def: person.xsl)

Omertron commented 9 years ago

Comment #17 originally posted by Omertron on 2011-05-11T19:53:04.000Z:

Hallo,

I'm from German and the designer of the Modyfiant-Skin, there can find of my Board: http://www.german-yamj-board.org

I have testet the new options from the revision r2346 with Peoples/Casts. It was nice, that the YAMJ-Team brings this Future, but i have some Problmes between the Function:

When i set the Parameter to "false" in the "My_Library.xml", all Infos of People are going down of the movie.xml. YAMJ dosen't search for the People Infos, if the Actors are standing in the NFO-File (i work with Ember). YAMJ doesn't load Photos for People. And the Scan is very slowly (yb five testmovie over 60min.) and the Jukebox becomes rather large;

Sorry for bad english, i hope, you understand me.

Are you already know these problems?

Omertron commented 9 years ago

Comment #18 originally posted by Omertron on 2011-05-12T15:17:50.000Z:

This issue was updated by revision r2353.

update the [PropertiesConfiguration] wiki page with the new options it added to the moviejukebox-default.properties file

Omertron commented 9 years ago

Comment #19 originally posted by Omertron on 2011-05-12T17:39:56.000Z:

This issue was updated by revision r2354.

scrapeLibrary option is now being used. Analyze NFO-File for personal information and use tag now. Set default return false to other pluging not supported person scanner.

Omertron commented 9 years ago

Comment #20 originally posted by Omertron on 2011-05-13T10:19:25.000Z:

This issue was updated by revision r2363.

correct photo scanner and add dummy photo image to default skin

Omertron commented 9 years ago

Comment #21 originally posted by Omertron on 2011-05-13T19:23:45.000Z:

Add limitation of people by popularity (count of movies where they appear) [Issue 1919] new options: mjb.people.popularity= - min popularity (count movies where person exists) to scan personal information (def: 5) mjb.people.popularity.maxCount= - max count of people when use popularity method (def: 100)

Omertron commented 9 years ago

Comment #22 originally posted by Omertron on 2011-05-13T19:47:41.000Z:

combined parameters mjb.people.maxCount and mjb.people.popularity.maxCount in one mjb.people.maxCount

Omertron commented 9 years ago

Comment #23 originally posted by Omertron on 2011-05-15T17:07:29.000Z:

This issue was updated by revision r2373.

Fixed empty person scanner

Omertron commented 9 years ago

Comment #24 originally posted by Omertron on 2011-05-16T05:25:49.000Z:

This issue was updated by revision r2377.

Append backward fill in personal information to the movies, put directors/writers to persons from NFO, find dups by name and job.

Omertron commented 9 years ago

Comment #25 originally posted by Omertron on 2011-05-16T08:37:19.000Z:

Issue 1923 has been merged into this issue.

Omertron commented 9 years ago

Comment #26 originally posted by Omertron on 2011-05-16T18:43:49.000Z:

Hallo,

I have my testjukebox completely deleted. but from r2366 the scan of personal data does not work. It will not be looking personal data, although the option is enabled. I have thoroughly tested all versions from r2366 to r2380. And: The photos are not downloaded from Internet

The NFO-Files are now processed correctly, thanks.

Omertron commented 9 years ago

Comment #27 originally posted by Omertron on 2011-05-17T03:14:14.000Z:

This issue was updated by revision r2383.

Cast enhancement is used in default skin. Increased scanning speed filmography. Separated the person's name from filename. Backward filling of links to movies in personal filmography. new options: plugin.people.skip.VG= - skip VideoGame on filmography scanner (def: true) plugin.people.skip.TV= - skip TeleVision on filmography scanner (def: false) plugin.people.skip.V= - skip Video on filmography scanner (def: false)

Omertron commented 9 years ago

Comment #28 originally posted by Omertron on 2011-05-17T03:22:45.000Z:

The issue is close to completion. Test capabilities and find errors.

Omertron commented 9 years ago

Comment #29 originally posted by Omertron on 2011-05-17T16:29:52.000Z:

This issue was updated by revision r2389.

Add new personal attribute 'doublage', containing the name of the actor voicing the role of the national dubbing. new option: plugin.people.maxCount= - count of people per movie (def: 15) plugin.people.maxCount.actor= - count of actor per movie (def: 10) plugin.people.maxCount.director= - count of director per movie (def: 2) plugin.people.maxCount.writer= - count of writer per movie (def: 3)

Omertron commented 9 years ago

Comment #30 originally posted by Omertron on 2011-05-17T19:53:43.000Z:

Might need to create a new category page that you can browse the people on.

Omertron commented 9 years ago

Comment #31 originally posted by Omertron on 2011-05-18T03:32:32.000Z:

This issue was updated by revision r2393.

Create a new category page that you can browse the people on. new option: indexing.completePerson= - indexing only people with complete personal information (def: true)

Omertron commented 9 years ago

Comment #32 originally posted by Omertron on 2011-05-18T11:52:58.000Z:

This issue was updated by revision r2395.

Add person attribute 'title' contains localization name. KinopoiskPlugin supports cast enhancement (not full yet).

Omertron commented 9 years ago

Comment #33 originally posted by Omertron on 2011-05-20T06:44:30.000Z:

This issue was updated by revision r2396.

KinopoiskPlugin full support cast enhancement now. Correct store/resore XML file.

Omertron commented 9 years ago

Comment #34 originally posted by Omertron on 2011-05-23T18:21:52.000Z:

Hello,

I still have any problems with the options "mjb.people.popularity" and "mjb.people.maxCount". If I use "mjb.people.popularity" and "mjb.people.maxCount" to "default", then at 500 Movies searched for little people. If I use "mjb.people.popularity" to -1, then search YAMJ me all the people at 500 Movies that makes the scan very very slowly (over 8h). A Rescan to find new Movies under these conditions is unacceptable.

It would be useful if the option "mjb.people = false" for a rescan not the existing person.htm would hide in the moviedetails, or "mjb.people = true" would be a rescan the existing skip persons as in the movies, thats a very nice.

I hope, you understand me.

Omertron commented 9 years ago

Comment #35 originally posted by Omertron on 2011-05-24T03:50:52.000Z:

If use default values "mjb.people.popularity" and "mjb.people.maxCount", then always search 10 popular person only. If use "mjb.people.popularity" to -1 and default value "mjb.people.maxCount", then of each film in 10 persons each job (director, writer, actor). I recommend using a "mjb.people.popularity" greater than zero and indicate a reasonable number of people in "mjb.people.maxCount". Hide the person in the moviedetails is not appropriate in the absence of personal data (person.htm). Cast enhancement because it is designed to replace the old structures directors/writers/cast. To determine whether the personal description should check the value tag . If "UNKNOWN", then not exists person.htm, otherwise there is a file name of personal data (person.htm).

Omertron commented 9 years ago

Comment #36 originally posted by Omertron on 2011-05-24T10:47:41.000Z:

This issue was updated by revision r2401.

KinopoiskPlugin use option "kinopoisk.rating" to form filmography. If value "avarage" or "combine" - filmography contains combining details from imdb and kinopoisk. new option: plugin.filmography.jobsInclude= - List of jobs included in the filmography (def: Director,Writer,Actor,Actress)

Omertron commented 9 years ago

Comment #37 originally posted by Omertron on 2011-05-24T15:51:56.000Z:

This issue was updated by revision r2406.

Indexing Cast/Director/Writer by personal data when option "mjb.people" is true and also use option "indexing.completePerson".

Omertron commented 9 years ago

Comment #38 originally posted by Omertron on 2011-05-25T05:25:57.000Z:

This issue was updated by revision r2407.

Removed the dependence new model of personal data on old model "cast/director/writer". Optimization of types Person&Filmography and their use: replace Person to Filmography on class Movie attribute people.

Omertron commented 9 years ago

Comment #39 originally posted by Omertron on 2011-05-26T14:31:53.000Z:

hi,

I have found another problem with tvshows: In although movie.xml be written in "people" names, but with "character","job" ect. is only "UNKNOWN"

Omertron commented 9 years ago

Comment #40 originally posted by Omertron on 2011-05-26T16:26:00.000Z:

Only 2 plugins fully use this enhancement: ImdbPlugin and KinopoiskPlugin. TheTvDBPlugin does not support an cast enhancement in full yet.

Omertron commented 9 years ago

Comment #41 originally posted by Omertron on 2011-05-26T18:22:04.000Z:

Ok, thanks.

I thought this would come about by imdb.

Omertron commented 9 years ago

Comment #42 originally posted by Omertron on 2011-05-28T00:53:39.000Z:

Where can I get the latest release to check this new feature?

Omertron commented 9 years ago

Comment #43 originally posted by Omertron on 2011-05-28T06:24:57.000Z:

http://mediaplayersite.com

Omertron commented 9 years ago

Comment #44 originally posted by Omertron on 2011-05-29T08:00:55.000Z:

Hi,

i'm found the error with with "character","job" ect. is only "UNKNOWN" in <people/person> by the tvshown-name.xml: I use NFOs with Casts/Actors inside. If i delete all casts/actors out of this NFO, then YAMJ scanned correctly and the Information is in the tvshow-name.xml. See my examples:

With Casts in the NFO:

Richard Dean Anderson

Without Casts in the NFO;

Richard Dean Anderson

I delete all the Cast/Actors out of my all NFOs and now it works correctly!

Omertron commented 9 years ago

Comment #45 originally posted by Omertron on 2011-05-29T14:56:09.000Z:

Some questions

  1. Is there a skin that supports the Cast feature?
  2. I do not see the index file been created, I got, Indexing Cast (7/8) contains 0 indexes, why?
UNKNOWN UNKNOWN

Should not it be indexed?

Thanks for the support

Omertron commented 9 years ago

Comment #46 originally posted by Omertron on 2011-05-30T08:27:03.000Z:

defi, I could not repeat the mistake with the above result. Need a probe NFO file. Scanner use tag on NFO file now. I do not understand why the job="UNKNOWN" with Casts in the NFO.

Omertron commented 9 years ago

Comment #47 originally posted by Omertron on 2011-05-30T10:10:21.000Z:

avi.klem, default skin supports the Cast feature only. Index "Cast" is not index "Cast enhancement", it uses the index "Person".

Omertron commented 9 years ago

Comment #48 originally posted by Omertron on 2011-05-30T11:03:37.000Z:

Hi,

i use this format in my NFO-Files:

My NFOs are older than on the wiki, so I have the TAG </ role> does not make in it. I thought YAMJ would also support older NFOs. It's not a Problem, i delete all Actor-Inforamtion out of the NFOs.

Omertron commented 9 years ago

Comment #49 originally posted by Omertron on 2011-05-30T14:39:09.000Z:

Hi,

I still can not get the "Cast enhancement" to work. I see the info on the movie xml file but I do not see any index been created and I can not see anything new while using the default skin.

What configuration is needed to open the feature?

The only configuration I did is with the mjb.categories.indexList

I put Cast, I put Person and ...nothing

Thanks for the advice

Avi

Omertron commented 9 years ago

Comment #50 originally posted by Omertron on 2011-05-31T03:54:20.000Z:

Use default skin from development trunk. To switch on this feature set mjb.people=true and mjb.includePhoto=true to view photos. To indexing people append "Person" to mjb.categories.indexList. More options you find in [PropertiesConfiguration] part "Persons". To view personal information on complete jukebox: on movie detail click to director or actor name.