search

YAMJ / yamj-v2

Yet Another Movie Jukebox (YAMJ) v2
GNU General Public License v3.0
28 stars 11 forks source link

TV show DVD sorting doesn't work #2026

Closed Omertron closed 9 years ago

Omertron commented 9 years ago

Original issue 2027 created by Omertron on 2011-07-04T23:50:05.000Z:

What steps will reproduce the problem?

thetvdb.dvd.episodes=true doesn't work. The DVD sort order from thtvdb seems not to be used.

What version/revision of YAMJ are you using? On what operating system? r2589, r2371

A good example is 'Futurama': the DVDSeason1 contains of episodes 1-13 but the aired order is TVSeason1/ep. 1-9, TVSeason2/ep. 10-13. In the current result with thetvdb.dvd.episodes=true episodes 1-9 show correct data whereas episodes 10-13 show UNKNOWN.

I guess that the problem started with r2259, with r2257 everything is correct.

Omertron commented 9 years ago

Comment #1 originally posted by Omertron on 2011-07-10T00:06:24.000Z:

I am having the same issue using the latest build

Omertron commented 9 years ago

Comment #2 originally posted by Omertron on 2011-07-20T16:51:48.000Z:

Hello,

I'm ahving the problem, too. Some of my series episode lists look horrible! Is this a yamj or a thetvdb.com problem??

Omertron commented 9 years ago

Comment #3 originally posted by Omertron on 2011-07-28T18:25:12.000Z:

It seems the 'findDvdEpisode' part doesn't work. After I replaced these parts with the old code from r2257 (after: if (dvdEpisodes)...) it worked again.

Omertron commented 9 years ago

Comment #4 originally posted by Omertron on 2011-07-28T18:38:42.000Z:

patch?

Omertron commented 9 years ago

Comment #5 originally posted by Omertron on 2011-07-28T19:31:19.000Z:

Attached my thetvdbplugin file.

But I guess you had a reason to change the dvdEpisodes part, so you should have a look at it first.

Omertron commented 9 years ago

Comment #6 originally posted by Omertron on 2011-07-28T22:27:39.000Z:

I just noticed that - with dvdepisodes=true - there might be a lot of API errors since not all TV shows have a DVD order in thetvdb. I don't care because the results were correct, but others may complain about that.

Omertron commented 9 years ago

Comment #7 originally posted by Omertron on 2011-07-29T07:30:48.000Z:

I can't remember if the DVD order returns the tv order if there's no dvd order.

Also there's an issue with dvd order being 1.2, 1.3 rather than 1, 2, etc.

I'll need to look into all of these issues

Omertron commented 9 years ago

Comment #8 originally posted by Omertron on 2011-07-29T10:30:40.000Z:

I tested it with a series that hasn't got a dvd order and the final YAMJ result was correct - but it of course showed API error messages.

Omertron commented 9 years ago

Comment #9 originally posted by Omertron on 2011-12-09T06:46:37.000Z:

also had problems getting this to work. I moved my entire collection to a temp folder, except for Farcscape, which I wanted DVD order for, and created a new jukebox with dvd order enabled. I tried: 2.5.1 Revision: r2754 2.6-SNAPSHOT Revision: r2822 2.6-SNAPSHOT Revision: r2831 and none of give DVD ordering.

I downloaded an older version v2.2 Revision: r1925 and it works perfectly well.

Omertron commented 9 years ago

Comment #10 originally posted by Omertron on 2011-12-28T16:02:13.000Z:

This issue was closed by revision r2859.