YAMJ fails to create poster images for TV shows with special characters in title "colon, back slash, etc"

Omertron commented 9 years ago

Original issue 2289 created by Omertron on 2012-01-20T05:42:34.000Z:

What steps will reproduce the problem? 1.create dummy files of Avatar The last Airbender, at least 2 episodes from each season 2.Run YAMJ 3.Navigate to Avatar position on the wall, no poster image

What is the expected output? No image

What do you see instead? Poster to appear

What version/revision of YAMJ are you using? Issue first started appearing in yamj-2.6-SNAPSHOT-r2885

On what operating system? Windows Home Server

What skin are you using? default Eversion

What device are you using YAMJ on? Networked Media Tank, PlayonHD, Other? NMT C200 NMT A200

Please provide any additional information below.

http://www.networkedmediatank.com/showthread.php?tid=57301&page=3

Omertron commented 9 years ago

Comment #1 originally posted by Omertron on 2012-01-20T06:05:38.000Z:

Additional info: Issue did not happen in 2.5-SNAPSHOT (R2717)

Omertron commented 9 years ago

Comment #2 originally posted by Omertron on 2012-01-20T13:56:01.000Z:

Aditional info:

This broke after 2.6-SNAPSHOT (R2871)

Omertron commented 9 years ago

Comment #3 originally posted by Omertron on 2012-01-20T14:36:04.000Z:

Confirmed

Omertron commented 9 years ago

Comment #4 originally posted by Omertron on 2012-01-23T18:54:56.000Z:

The first season title scraped from thetvdb is used for the file name of the poster thumbnail on the wall. Even if you have set an alternative title in this does not get used (and is not shown as the title of the show).</p> <p>If this file name contains for example a ':' or a '*' (characters that are not allowed in file names), the associated graphics doesn't seem to be generated (as this is normally not legal under most file systems).</p> <p>An example of a show that does this is: <a href="http://thetvdb.com/?tab=season&seriesid=73893&seasonid=6617&lid=7">http://thetvdb.com/?tab=season&seriesid=73893&seasonid=6617&lid=7</a></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Omertron"><img src="https://avatars.githubusercontent.com/u/1432853?v=4" />Omertron</a> commented <strong> 9 years ago</strong> </div> <div class="markdown-body"> <p>Comment <a href="https://code.google.com/p/moviejukebox/issues/detail?id=2289#c5">#5</a> originally posted by Omertron on 2012-01-23T19:21:06.000Z:</p> <p>Poked around a bit more and found a possible workaround (YMMV)...</p> <p>If you name the directory of the files EXACTLY as the prefix for the episodes, ie. something like this: Star Trek Enterprise/Star Trek Enterprise 1x03 - Fight Or Flight.avi then the wall pictures WILL show as they're now named (in this case): Set_Star Trek Enterprise_1_small.png Before they'd be named something like: Set_Star Trek%243A Enterprise_1_small.png</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Omertron"><img src="https://avatars.githubusercontent.com/u/1432853?v=4" />Omertron</a> commented <strong> 9 years ago</strong> </div> <div class="markdown-body"> <p>Comment <a href="https://code.google.com/p/moviejukebox/issues/detail?id=2289#c6">#6</a> originally posted by Omertron on 2012-01-24T22:06:48.000Z:</p> <p>Hi,</p> <p>I'm having this same issue but cannot figure out the workaround.</p> <p>From above it seems that you are advocating changing the directory name by removing the dashes. I've done this and it is still happening on many of my movies. </p> <p>It's NOT that the set poster is incorrectly named, it's that YAMJ is NOT generating ANY Set poster for the movie Set_Star Trek$3A Deep Space Nine_1.banner is a file that comes out, while it's not the set poster it does show that YAMJ doesn't care what my movie is named, it is NOT going to generate the Set poster.</p> <p>Could you more clearly explain your workaround?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Omertron"><img src="https://avatars.githubusercontent.com/u/1432853?v=4" />Omertron</a> commented <strong> 9 years ago</strong> </div> <div class="markdown-body"> <p>Comment <a href="https://code.google.com/p/moviejukebox/issues/detail?id=2289#c7">#7</a> originally posted by Omertron on 2012-01-24T22:12:34.000Z:</p> <p>It takes the name for the poster file from what it scrapes off thetvdb, where it should take it from the NFO file... If this name contains characters that can not be used in file names, like ':' or '*', then the file will not be generated.</p> <p>It wasn't just a matter of removing dashes, that didn't work... The workaround I found working for me was to name the directory EXACTLY as the prefix of the episodes, in the above example it is 'Star Trek Enterprise'. This then creates poster file names from this for some reason.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Omertron"><img src="https://avatars.githubusercontent.com/u/1432853?v=4" />Omertron</a> commented <strong> 9 years ago</strong> </div> <div class="markdown-body"> <p>Comment <a href="https://code.google.com/p/moviejukebox/issues/detail?id=2289#c8">#8</a> originally posted by Omertron on 2012-01-24T23:08:17.000Z:</p> <p>Since it's getting the info from theTVDB then it doesn't matter that I have set poster images, right? Nothing will change as a result of the naming of those images then?</p> <p>Onto the naming of the directories. Both of my directories were named identically to the TV Shows but it's still not working. Here is what I have:</p> <p>Directory Name - Penn & Teller Bullshit! (I previously had this named as Penn & Teller- Bullshit!) Filename - Penn & Teller- Bullshit!.S01E01.Talking to the Dead</p> <p>Directory Name - Star Trek Deep Space Nine (I previously had this named as Star Trek- Deep Space Nine) Filename - Star Trek- Deep Space Nine.S01E01_02.Emissary (1)</p> <p>In the two above examples could you please tell me exactly how to name the directory and if I should change the filename in any way?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Omertron"><img src="https://avatars.githubusercontent.com/u/1432853?v=4" />Omertron</a> commented <strong> 9 years ago</strong> </div> <div class="markdown-body"> <p>Comment <a href="https://code.google.com/p/moviejukebox/issues/detail?id=2289#c9">#9</a> originally posted by Omertron on 2012-01-25T00:46:11.000Z:</p> <p>I use spaces, not '.', before the episode. That might matter...</p> <p>Also, if you have 'Star Trek Deep Space Nine' as the directory, then the file must also have the prefix 'Star Trek Deep Space Nine' (at least that's how I got it to work). Yours has the '-' in them. Dashes are sometimes handled in strange and not always logical ways by YAMJ...</p> <p>Mine follow this form and works:</p> <series>/<series> <episode#> - <title>.avi though I had to fiddle around a bit before I got it working. If the <series> part was even slightly different between the two instances (including letter case), it didn't work. </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Omertron"><img src="https://avatars.githubusercontent.com/u/1432853?v=4" />Omertron</a> commented <strong> 9 years ago</strong> </div> <div class="markdown-body"> <p>Comment <a href="https://code.google.com/p/moviejukebox/issues/detail?id=2289#c10">#10</a> originally posted by Omertron on 2012-01-25T06:44:26.000Z:</p> <p>Name any season artwork the sams as the folders the files are in Season 1\Season 1.jpg Set artwork should be named the same as what is produced in the Jukebox.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Omertron"><img src="https://avatars.githubusercontent.com/u/1432853?v=4" />Omertron</a> commented <strong> 9 years ago</strong> </div> <div class="markdown-body"> <p>Comment <a href="https://code.google.com/p/moviejukebox/issues/detail?id=2289#c11">#11</a> originally posted by Omertron on 2012-01-25T09:33:02.000Z:</p> <p>Hi Stuart,</p> <p>Here are 3 shows that do not produce Set Poster art within the YAMJ Jukebox folder due to them having a special character, a dash - within the file names.</p> <p>Show Name: Penn & Teller- Bullshit! Show Set Art Filename: Set_Penn & Teller Bullshit!_1.jpg Expected YAMJ Jukebox output filenames: Set_Penn & Teller Bullshit!_1_large.jpg & Set_Penn & Teller Bullshit!_1_small.jpg</p> <p>Show Name: Star Trek- Deep Space Nine Show Set Art Filename: Set_Star Trek- Deep Space Nine_1.jpg Expected YAMJ Jukebox output filenames: Set_Penn & Teller- Bullshit!_1_large.jpg Set_Penn & Teller- Bullshit!_1_small.jpg</p> <p>Show Name: Terminator- The Sarah Connor Chronicles Show Set Art Filename: Set_Terminator- The Sarah Connor Chronicles_1.jpg Expected YAMJ Jukebox output filenames: Set_Terminator- The Sarah Connor Chronicles_1_large.jpg & Set_Terminator- The Sarah Connor Chronicles_1_small.jpg</p> <p>Although YAMJ does NOT produce the Set Poster art, it does produce the fanart, banner and .xml files but each of these files is substituting $3A in place of the - character. As an example, here are the Penn & Teller files that are outputted to the Jukebox folder:</p> <p>Set_Penn & Teller$3A Bullshit!_1.banner.jpg Set_Penn & Teller$3A Bullshit!_1.fanart Set_Penn & Teller$3A Bullshit!_1</p> <p>Now here is something I cannot explain, the show below also failed to produce a file name many times, but for some reason when I ran YAMJ this morning it did work. Doesn't matter though as it didn't work for the others but I wanted to bring it to your attention.</p> <p>Spartacus- Gods of the Arena Set_Spartacus- Gods of the Arena_1_large.jpg Set_Spartacus- Gods of the Arena_1_small.jpg</p> <p>Notice the dash just like the others? Weird, huh?</p> <p>Hopefully this follows your requirements of concise, detailed and with the actual filenames and hopefully it won't take too long to find or fix </p> <p>Rob</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Omertron"><img src="https://avatars.githubusercontent.com/u/1432853?v=4" />Omertron</a> commented <strong> 9 years ago</strong> </div> <div class="markdown-body"> <p>Comment <a href="https://code.google.com/p/moviejukebox/issues/detail?id=2289#c12">#12</a> originally posted by Omertron on 2012-02-04T18:21:57.000Z:</p> <p>This issue was closed by revision r2923.</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>

YAMJ / yamj-v2

YAMJ fails to create poster images for TV shows with special characters in title "colon, back slash, etc" #2288