search

YAMJ / yamj-v2

Yet Another Movie Jukebox (YAMJ) v2
GNU General Public License v3.0
28 stars 11 forks source link

When getting genres from imdb, all genres should be retrieved and not by the skin properties (imdb.genres.max) #233

Closed Omertron closed 9 years ago

Omertron commented 9 years ago

Original issue 233 created by Omertron on 2008-10-18T13:29:39.000Z:

What steps will reproduce the problem?

  1. Set skin imdb.genres.max to 1
  2. Run jukebox
  3. Set skin imdb.genres.max to 3
  4. Run jukebox

What is the expected output? What do you see instead? The XML file will still have 1 genre and not 3

I think that when running the imdb crawler, all genres should be retrieved and save in the XML, but when generated the HTML it should be a configurable number

Omertron commented 9 years ago

Comment #1 originally posted by Omertron on 2008-10-18T15:03:47.000Z:

I accept that this may be a problem, but I think that it's a low priority because I do not expect many users to change this property on a regular basis.

I believe that you should decide how many genres you want when you first generate the jukebox.

Omertron commented 9 years ago

Comment #2 originally posted by Omertron on 2008-10-18T20:13:05.000Z:

Although it can't be a very difficult thing to fix in the code, and could be done in little time. Doing so would not affect current users or any current skins.

Omertron commented 9 years ago

Comment #3 originally posted by Omertron on 2008-10-19T08:59:17.000Z:

Due to the way that the html is created, using the java class TransformerFactory, and not an inbuilt routine, this is not going to be fixed for the small gain that it would provide.

Perhaps you can explain why you need this and we can look at another way to achieve the same result

Omertron commented 9 years ago

Comment #4 originally posted by Omertron on 2008-10-19T10:15:27.000Z:

I just think it would be more logical.

When getting data from IMDB, it's better to get it all because it makes it more flexible to work with it later.

But it makes sense that the solution is not so intuitive. I understand that the XSL runs on the original XML files?

Omertron commented 9 years ago

Comment #5 originally posted by Omertron on 2008-10-19T12:21:58.000Z:

There is no way to separate out the genres from the xml file after they have been written by the IMDB scraper.

Yes the XSL runs against the XML to generate the HTML files.