search

YAMJ / yamj-v2

Yet Another Movie Jukebox (YAMJ) v2
GNU General Public License v3.0
28 stars 11 forks source link

Yamj overwrite XML nfo and poster at everytime #2402

Closed Omertron closed 9 years ago

Omertron commented 9 years ago

Original issue 2403 created by Omertron on 2012-04-10T09:37:42.000Z:

What steps will reproduce the problem?

1.launch yamj with empty jukebox

2.re run yamj (with no change in the properties or no movie added)

What is the expected output? What do you see instead?

the same step work fine with Ymaj r3000 (v 2.6.1)

yamj : r3036 java : 1.7.0.3 os : windows 7 x64 skin : eversion

Omertron commented 9 years ago

Comment #1 originally posted by Omertron on 2012-04-10T10:27:47.000Z:

Could you narrow down the release that this problem occurs in?

Omertron commented 9 years ago

Comment #2 originally posted by Omertron on 2012-04-10T11:42:19.000Z:

this problem occurs in r3027.

Omertron commented 9 years ago

Comment #3 originally posted by Omertron on 2012-04-10T22:45:24.000Z:

I have upgraded from r3016 to r3027 and have also noted the regeneration and overwriting of movie posters - this is also noted in issue 2401. I am not generating NFO files, so cannot comment on that. I am running on Win7 32 bit and keep posters and fanart with all movies and some tv shows Looking at my log files, Fanart is behaving as expected but Posters are not

  1. New TV or Movie: Posters copied from folders as expected
  2. Existing TV or Movie without Poster in folder - no poster downloaded, XML not regenerated.
  3. Existing TV or Movie with Poster in folder - new poster downloaded, XML regenerated.
Omertron commented 9 years ago

Comment #4 originally posted by Omertron on 2012-04-10T22:47:18.000Z:

I have upgraded from r3016 to r3037 and have also noted the regeneration and overwriting of movie posters - this is also noted in issue 2401. I am not generating NFO files, so cannot comment on that. I am running on Win7 32 bit and keep posters and fanart with all movies and some tv shows Looking at my log files, Fanart is behaving as expected but Posters are not

  1. New TV or Movie: Posters copied from folders as expected
  2. Existing TV or Movie without Poster in folder - no poster downloaded, XML not regenerated.
  3. Existing TV or Movie with Poster in folder - new poster downloaded, XML regenerated.
Omertron commented 9 years ago

Comment #5 originally posted by Omertron on 2012-04-11T10:08:08.000Z:

As noted above, the problem first arises in r3027 (r3026 behaves normally) and is still manifesting in r3037

Omertron commented 9 years ago

Comment #6 originally posted by Omertron on 2012-04-11T11:18:14.000Z:

Issue 2401 has been merged into this issue.

Omertron commented 9 years ago

Comment #7 originally posted by Omertron on 2012-04-12T08:47:16.000Z:

I don't know if this can help you:

All posters are already downloaded in a directory before run YAMJ. In all "file movies.xml" I have something like this for "urlposter" before r3027:

file%3A%2FD%3A%2Ftest%2FHeat%2FHeat.1995.brrip.xvid.jpg

when I update YAMJ to r3027 and over I always have this the first time :

http%3A%2F%2Fimages.allocine.fr%2Fmedias%2Fnmedia%2F00%2F02%2F56%2F90%2Faff.jpg

If I re run YAMJ with the same update the value becomes as before with r3026

file%3A%2FD%3A%2Ftest%2FHeat%2FHeat.1995.brrip.xvid.jpg

And sometime not always I have lot of error with plugin Allocine since r3027. (see attached file moviejukebox.ERROR.r3027.log) If I downgrade to r3026 There is never error.

Omertron commented 9 years ago

Comment #8 originally posted by Omertron on 2012-04-12T09:29:50.000Z:

I think I know what the issue is, I just need to trace it down

Omertron commented 9 years ago

Comment #9 originally posted by Omertron on 2012-04-12T17:53:59.000Z:

Update since r3041. The problem now also affects fanart for existing movies if the fanart is stored with the movie. If fanart in is the jukebox but not stored locally, then there is no attempt to retrieve. If fanart in is the jukebox and stored locally, then the local file is retrieved.

Omertron commented 9 years ago

Comment #10 originally posted by Omertron on 2012-04-13T13:00:17.000Z:

This issue was closed by revision r3043.

Omertron commented 9 years ago

Comment #11 originally posted by Omertron on 2012-04-13T14:12:56.000Z:

Just for your information.

It is better, thanks :

But if I use r3026 only 1325 file was updated in jukebox

But if I use r3026 only 5981 file was updated in jukebox

Omertron commented 9 years ago

Comment #12 originally posted by Omertron on 2012-04-13T14:17:32.000Z:

In the last sentence I meant this

if I use r3043 5981 file was updated in jukebox

Omertron commented 9 years ago

Comment #13 originally posted by Omertron on 2012-04-13T16:40:46.000Z:

As noted above, the Posters are no longer being pulled from the internet, however they are still being pulled from their local directories (mine are stored with the movies/TV series). Up to r3026 Posters were only pulled for a new movie/tv or where there had been a change (e.g. new NFO).

Should this be flagged as a continuation of 2403 or posted as a new issue?

Omertron commented 9 years ago

Comment #14 originally posted by Omertron on 2012-04-13T17:18:20.000Z:

You might need to run it again for it to "settle down"

Omertron commented 9 years ago

Comment #15 originally posted by Omertron on 2012-04-13T17:53:03.000Z:

Already done :)

Omertron commented 9 years ago

Comment #16 originally posted by Omertron on 2012-04-13T17:53:49.000Z:

I will make a test with empty jukebox.

Omertron commented 9 years ago

Comment #17 originally posted by Omertron on 2012-04-13T18:36:13.000Z:

I have always the same things. thumbnails and posters are updated from local files.

Omertron commented 9 years ago

Comment #18 originally posted by Omertron on 2012-04-13T20:26:51.000Z:

Updated by r3044 Finally properly fixed this time!

Omertron commented 9 years ago

Comment #19 originally posted by Omertron on 2012-04-13T20:53:15.000Z:

Yes all is fine this time, thanks.