YAMJ / yamj-v2

Yet Another Movie Jukebox (YAMJ) v2
GNU General Public License v3.0
28 stars 11 forks source link

Overlay XML Banners Resize #2438

Closed Omertron closed 9 years ago

Omertron commented 9 years ago

Original issue 2439 created by Omertron on 2012-06-23T18:04:21.000Z:

What steps will reproduce the problem?

  1. Run YAMJ with overlays
  2. See resulting banners 3.

What is the expected output? What do you see instead? Banners downloaded by YAMJ are correctly resized. Banners taken from local folders aren't resized.

What version/revision of YAMJ are you using? On what operating system? yamj-2.7-SNAPSHOT-r3138-bin.zip

What skin are you using? Eversion / evHell

What device are you using YAMJ on? Networked Media Tank, PlayonHD, Other? PCH C-200

Please provide any additional information below. Both included banners are from the same run with the following overlay settings:

# banners size and format
banners.format=png
banners.width=452
banners.height=83
banners.normalize=false
posters.stretch=true

# banners effects
banners.roundCorners=true
banners.cornerRadius=10
banners.cornerQuality=50

# banners overlay
banners.xmlOverlay=true
banners.xmlOverlayFile=banner_clean.xml
banners.overlay=true
banners.overlay.source=default
banners.overlay.offsetX=2
banners.overlay.offsetY=5

# banners settings
banners.logoSet=true
banners.rating=true
banners.watched=true
Omertron commented 9 years ago

Comment #1 originally posted by Omertron on 2012-06-23T19:06:36.000Z:

I have seen the same for posters and thumbnails. I normally have no local files, but some of the users of evHell seems to have mostly local files.

Omertron commented 9 years ago

Comment #2 originally posted by Omertron on 2012-06-26T04:54:37.000Z:

It also seems the poster and thumbnail are mixed up. smartposter1large: returns the thumbnail smartposter1small: returns the poster

I've made the above images the same size so it wasn't obvious with my overlay, the difference is that the thumbnail has a reflection.

Omertron commented 9 years ago

Comment #3 originally posted by Omertron on 2012-06-26T05:58:07.000Z:

Have you checked the files on disk?

I'm about to start refactoring the code for poster / banner / fanart scanning in the coming versions, so I may hold off on this one until that's done.

Omertron commented 9 years ago

Comment #4 originally posted by Omertron on 2012-06-26T11:06:30.000Z:

The files on disk are ok, they've been there for a while, nothing new or changed since at least half a year.

Omertron commented 9 years ago

Comment #5 originally posted by Omertron on 2012-06-26T23:18:16.000Z:

I've recommended users to let YAMJ dl all artwork as a partial workaround and released a beta with possibility to choose whether to use poster or thumb per page.

Hopefully that will suffice until refactoring has been done.

http://forum.dentedboxes.com/thread-1359-page-17.html

Omertron commented 9 years ago

Comment #6 originally posted by Omertron on 2012-06-27T18:24:25.000Z:

Don't know if it is of any help to you but I just saw that the overlay is applied multiple times for set banners.

Omertron commented 9 years ago

Comment #7 originally posted by Omertron on 2012-07-04T02:10:10.000Z:

Every time YAMJ is rerun it seems that the multiple overlay just gets worse. On the first run, one might get the outline box, ratings and set images around the banner appearing twice or three times (per comment 6 above) but on the second or third YAMJ scan the outline box, etc begin to get worse.

Omertron commented 9 years ago

Comment #8 originally posted by Omertron on 2012-07-05T10:14:45.000Z:

Deleting the offending banners and associated TV show files doesn't remove the show from the TV show wall for some reason. I don't run YAMJ everyday but very soon I won't see the banner at all due to this issue.

Omertron commented 9 years ago

Comment #9 originally posted by Omertron on 2012-07-16T20:05:15.000Z:

Issue 2417 has been merged into this issue.

Omertron commented 9 years ago

Comment #10 originally posted by Omertron on 2012-12-12T20:47:33.000Z:

I can't replicate this at all, so I don't know how to fix it.

Omertron commented 9 years ago

Comment #11 originally posted by Omertron on 2012-12-13T11:14:10.000Z:

Hi Stuart

Is there a way I can send you my set up (smallish test bed - 20GB (could cut out the HD movies easily as they're not a problem) so you can test it your end and see if you experience the same issue?

Omertron commented 9 years ago

Comment #12 originally posted by Omertron on 2012-12-13T12:41:03.000Z:

I only need 1 or 2 example shows that work, I don't need the whole jukebox.

If you can provide the settings files, I can setup eversion and whatever the skin is. Upload it to something like dropbox, box, skydrive, etc and I can get the link from you

Omertron commented 9 years ago

Comment #13 originally posted by Omertron on 2012-12-14T10:28:55.000Z:

This problem stems from the fact that there is no original file banner. So if you change the state of the series (ex, see the last series), the overlay is applied to the newly revised banner. Оr we must keep the original banner, or download it every time before apply overlay.

Omertron commented 9 years ago

Comment #14 originally posted by Omertron on 2012-12-14T14:12:29.000Z:

Hi Stuart

I have uploaded my Yamj test bed with my YAMJ set up (e.g. properties, skins, etc) plus the first episode in each of the TV shows concerned to Dropbox (https://dl.dropbox.com/u/78351582/YAMJ.zip). The first time you run it, everything will be fine but if you then add another TV show and run again you will, I think, see the issue above. Add another one and run again and the issue exacerbates itself.

Would you also mind seeing if you can replicate issues 1 and 3 from this link: http://www.networkedmediatank.com/showthread.php?tid=55896&pid=589062#pid589062

Many thanks Adrian

Omertron commented 9 years ago

Comment #15 originally posted by Omertron on 2012-12-14T14:22:08.000Z:

@ ilgi - sorry if I'm misunderstanding but I store all my artwork locally with the media files so there is an original banner.

Omertron commented 9 years ago

Comment #16 originally posted by Omertron on 2012-12-14T15:58:25.000Z:

@hairyhippy, 1Gb - it is cruel. Just pack folder YAMJ (without movies) and the main log. Your original banner will not be used if there is a banner in the media library and there he is already applied overlay.

Omertron commented 9 years ago

Comment #17 originally posted by Omertron on 2012-12-14T17:48:51.000Z:

@ ilgi - are you saying post first run my original banner won't be used? I'm fairly sure that when the YAMJ cmd is run it for the 1st time it will look for locally stored artwork rather than downloading from the web. 2nd run and there after it will look in the jukebox itself to see if already "created", no?

Re the file size, it contains some of the TV shows and associated banners that are causing the issue because the issue is not affecting all TV Shows just some. The reason I've done it this way is Stuart stated that he was unable to replicate the issue and therefore if he uses my exact same set up he will be able to see where the issue is more easily. Happy to change it if makes it easier to identify and solve the issue.

Omertron commented 9 years ago

Comment #18 originally posted by Omertron on 2012-12-14T17:49:01.000Z:

This issue was closed by revision r3342.

Omertron commented 9 years ago

Comment #19 originally posted by Omertron on 2012-12-14T17:58:44.000Z:

@hairyhippy - yes: locally stored artwork and downloading from the web are same thing when using the overlay. If TV show is static, then the problem is not identified. It appears there is only between successive scan TV series changed (add new series, change the status of watched TV show).

Omertron commented 9 years ago

Comment #20 originally posted by Omertron on 2012-12-14T18:00:50.000Z:

@hairyhippy - report any errors of the new processing method of banners

Omertron commented 9 years ago

Comment #21 originally posted by Omertron on 2012-12-14T18:28:19.000Z:

Sorry ilgi I don't know what you mean by "report any errors of the new processing method of banners" - do you mean this will be in the log somewhere?

And this issue will occur regardless of adding/modifying anything. If you do not modify or add anything and re-run the YAMJ cmd, the overlay issue becomes worse.

Omertron commented 9 years ago

Comment #22 originally posted by Omertron on 2012-12-14T18:29:33.000Z:

@ ilgi - I see you have closed this issue under r3342, sorry I didn't notice that earlier. I will test it now and report back.

Omertron commented 9 years ago

Comment #23 originally posted by Omertron on 2012-12-14T18:36:14.000Z:

@ ilgi - A huge thank you and sorry for any confusion above! Really appreciate you fixing this!!!

Omertron commented 9 years ago

Comment #24 originally posted by Omertron on 2012-12-22T09:54:40.000Z:

i confirm, banner is now correct with R3342 and later (tested with R3392) thanks a lot

Omertron commented 9 years ago

Comment #25 originally posted by Omertron on 2013-01-23T09:37:17.000Z:

This breaks more than it fixes. Local banners are not respected any more and set banners are not picked up.

I'll look at fixing this with the ArtworkScanner

Omertron commented 9 years ago

Comment #26 originally posted by Omertron on 2013-01-31T12:50:20.000Z:

<empty>

Omertron commented 9 years ago

Comment #27 originally posted by Omertron on 2013-05-08T08:20:51.000Z:

Fixed with r3701