YAMJ / yamj-v2

Yet Another Movie Jukebox (YAMJ) v2
GNU General Public License v3.0
28 stars 11 forks source link

Different people with same name not handled by YAMJ #2502

Closed Omertron closed 8 years ago

Omertron commented 9 years ago

Original issue 2503 created by Omertron on 2012-10-14T23:58:33.000Z:

What steps will reproduce the problem?

  1. add "2001: A Space Odyssey" and "Sin City" to your video library
  2. run YAMJ
  3. When you go to people page "Sin City" writer/director Frank Miller has Bio information for Frank Miller voice of mission control in "2001"

What is the expected output? What do you see instead? Separate entries for each of the Frank Millers.

What version/revision of YAMJ are you using? On what operating system? 2.8-SNAPSHOT Revision: r3199 Windows 7

What skin are you using? evHell 4.0 201209011400/eversion 0.2.8.16 (R0177)

What device are you using YAMJ on? Networked Media Tank, PlayonHD, Other? C200

Please provide any additional information below. There doesn't appear to be a way to handle people with the same name If you search IMDB for Frank Miller

http://www.imdb.com/find?q=Frank+Miller&s=all

there are at least 22. At least two of them directors.

Perhaps it should be possible in the .nfo file to add an ID to a person similar to the IDs for films eg

<actor> <id persondb="imdb">nm0588339</id> <id persondb="someOtherDB">OtherDBident</id> <name>Frank Miller</name> <role>Mission Controller (voice)</role> </actor>

Unfortunately I can't think of how to handle directors except with something like this -

<director> <id persondb="imdb">nm0588340</id> <name>Frank Miller</name> </director>

Thanks Gary

Omertron commented 9 years ago

Comment #1 originally posted by Omertron on 2012-11-20T19:26:01.000Z:

I've tested a little bit around and figured out that the person scraping works as desired.

When you look at the XML-Files for both films, then the IMDB-ID ist set correctly.

The problem when initialy creating the .xml is, that as filename for this file the persons name will be used. So just one file exists, if a person is listed twice, but with different IMDB-IDs.

To solve this problem the filename of the .xml should be set to sometking like <persons'name>-.xml.