YAMJ / yamj-v2

Yet Another Movie Jukebox (YAMJ) v2
GNU General Public License v3.0
28 stars 11 forks source link

Support DVD order from TheTVDB.com #281

Open Omertron opened 9 years ago

Omertron commented 9 years ago

Original issue 281 created by Omertron on 2008-11-21T23:25:33.000Z:

Please add support to optionally match episodes by DVD order instead of Aired Order.

Firefly is a good example of this

http://www.thetvdb.com/index.php?tab=season&seriesid=78874&seasonid=15791&lid=7&order=dvd

My first Firefly episode is named

Firefly - 1x01 - Serenity.avi

Omertron commented 9 years ago

Comment #1 originally posted by Omertron on 2008-11-22T10:54:56.000Z:

<empty>

Omertron commented 9 years ago

Comment #2 originally posted by Omertron on 2009-01-05T20:50:29.000Z:

Currently TheTVDB API does not support querying by DVD episode number, just the aired episode number. But I'll look into it to see if there is another way.

Omertron commented 9 years ago

Comment #3 originally posted by Omertron on 2009-01-05T20:57:55.000Z:

I see that TheTVDB does have DVD specific queries in their API. Looking into it.

Omertron commented 9 years ago

Comment #4 originally posted by Omertron on 2009-01-06T04:31:57.000Z:

Added: thetvdb.dvd.episodes=false to moviejukebox.properties change this to "true" to enable querying episodes at thetvdb based on DVD episode number

Omertron commented 9 years ago

Comment #5 originally posted by Omertron on 2009-01-06T09:01:20.000Z:

what happens when it is set to true and there are no dvd episode numbers specified at thetvdb?

Will it revert to the default numbering?

Omertron commented 9 years ago

Comment #6 originally posted by Omertron on 2009-01-06T15:27:38.000Z:

oh, so now you come up with alternate flows. good timing. ;) I'll look into it.

Omertron commented 9 years ago

Comment #7 originally posted by Omertron on 2009-01-06T15:34:46.000Z:

it does now. :)

Omertron commented 9 years ago

Comment #8 originally posted by Omertron on 2009-02-22T23:59:43.000Z:

This doesn't seem to be defaulting to the 'normal' order when there is no DVD order found. Spits out errors instead. See http://www.networkedmediatank.com/showthread.php?tid=15649&pid=148322#pid148322 onwards

Omertron commented 9 years ago

Comment #9 originally posted by Omertron on 2009-02-23T07:14:44.000Z:

<empty>

Omertron commented 9 years ago

Comment #10 originally posted by Omertron on 2009-02-23T08:14:39.000Z:

Hang on though. Despite all the errors (and there are a lot), it does kind of work. The file names still show up in the details pages, but I have issues scrolling them. Say I start at episode one, then press the down key on the remote, instead of going to episode 2 it skips down to a random point (maybe episode 10, or 6, or 12). Seems random. I'm not sure if this is related or not to be honest, but something definitely isn't working somewhere :D

Omertron commented 9 years ago

Comment #11 originally posted by Omertron on 2009-03-04T22:11:47.000Z:

<empty>

Omertron commented 9 years ago

Comment #12 originally posted by Omertron on 2009-03-04T23:03:10.000Z:

Ok, with regards to my above comment, it only does that (the skipping thing) when I also have 'show episode names' enabled. At the moment, I have that option disabled (so it just shops Episode 1, Episode 2 etc). I still get the error each time a new tv show is scraped, however it appears to work fine so I'm not sure what the error is for. Hope that helps narrow it down a bit ;)

Omertron commented 9 years ago

Comment #13 originally posted by Omertron on 2009-06-18T16:57:28.000Z:

This has been working fine for me for a couple months now. The only improvement I would like it fewer(no) error messages when there isn't a DVD episode number, but there is a normal episode number.

Omertron commented 9 years ago

Comment #14 originally posted by Omertron on 2009-08-07T09:37:39.000Z:

wouldn't it be better to handle this using the HDTV or Bluray filename tags that YAMJ allready detects? That way it would go right automatically, depending on what release you happen to have, and you can change your settings per series (have dvd order in one, tv order in the other).

Omertron commented 9 years ago

Comment #15 originally posted by Omertron on 2011-07-11T04:04:52.000Z:

Is there more progress on this because it appears to be broken in recent builds?