Closed Omertron closed 9 years ago
Comment #1 originally posted by Omertron on 2009-02-15T15:51:27.000Z:
<empty>
Comment #2 originally posted by Omertron on 2009-02-15T18:35:17.000Z:
Yep. I prefer the NFO method personally, but either way I'd love to see this implemented :)
Comment #3 originally posted by Omertron on 2009-02-15T20:44:24.000Z:
I'm all for this, it would help clean up my 60 page "All" section! I prefer the NFO method as well, but as long as we can group things, I'm not going to be picky.
Comment #4 originally posted by Omertron on 2009-02-16T11:54:05.000Z:
Yes, I'm keen on this improvement. The nfo method is preferred.
Comment #5 originally posted by Omertron on 2009-02-16T12:04:18.000Z:
Since it's 3-0 for nfo's I'll throw my preference in for filename prefix. I don't think this should become a poll though. Hopefully it'll support both.
Comment #6 originally posted by Omertron on 2009-02-17T02:03:11.000Z:
No, For example: "{Alien-1} Alien.mkv" "{Alien-2} Aliens.mkv" "{Alien-3} Alien 3.mkv" "{Alien-4} Alien Resurrection.mkv"
that sucks ;)
Besides using an nfo file, the most logical is leaving the filenames alone and placing related movies together under the same folder. They can be all together or also create sub-folders (like TV seasons) for each movie Aliens.1080p.BluRay.DTS.x264-group/ Aliens.1080p.BluRay.DTS.x264-group/Aliens.1080p.BluRay.DTS.x264-group.nfo Aliens.1080p.BluRay.DTS.x264-group/Aliens.1080p.BluRay.DTS.x264-group.jpg or folder.jpg Aliens.1080p.BluRay.DTS.x264-group/Alien 1979.jpg Aliens.1080p.BluRay.DTS.x264-group/Alien 1979.mkv Aliens.1080p.BluRay.DTS.x264-group/Alien 1979.nfo Aliens.1080p.BluRay.DTS.x264-group/Aliens 1986.jpg Aliens.1080p.BluRay.DTS.x264-group/Aliens 1986.mkv Aliens.1080p.BluRay.DTS.x264-group/Aliens 1986.nfo Aliens.1080p.BluRay.DTS.x264-group/Alien 3 1992.jpg Aliens.1080p.BluRay.DTS.x264-group/Alien 3 1992.mkv Aliens.1080p.BluRay.DTS.x264-group/Alien 3 1992.nfo ...
or Aliens.1080p.BluRay.DTS.x264-group/ Aliens.1080p.BluRay.DTS.x264-group/Aliens.1080p.BluRay.DTS.x264-group.nfo Aliens.1080p.BluRay.DTS.x264-group/Aliens.1080p.BluRay.DTS.x264-group.jpg or folder.jpg Aliens.1080p.BluRay.DTS.x264-group/Alien 1979/ Aliens.1080p.BluRay.DTS.x264-group/Alien 1979/Alien 1.jpg Aliens.1080p.BluRay.DTS.x264-group/Alien 1979/Alien 1.mkv Aliens.1080p.BluRay.DTS.x264-group/Alien 1979//Alien 1.nfo Aliens.1080p.BluRay.DTS.x264-group/Aliens 1986/Alien 2.jpg Aliens.1080p.BluRay.DTS.x264-group/Aliens 1986/Alien 2.mkv Aliens.1080p.BluRay.DTS.x264-group/Aliens 1986/Alien 2.nfo Aliens.1080p.BluRay.DTS.x264-group/Alien 3 1992/Alien 3.jpg Aliens.1080p.BluRay.DTS.x264-group/Alien 3 1992/Alien 3.mkv Aliens.1080p.BluRay.DTS.x264-group/Alien 3 1992/Alien 3.nfo ...
One of the naming conventions I like to use is including movie order right after the primary part of the name, followed by specific name: Cheech.And.Chong.Collection\Cheech.And.Chong.1.Up.In.Smoke.1978.mkv Cheech.And.Chong.Collection\Cheech.And.Chong.2.Next.Movie.1980.mkv Cheech.And.Chong.Collection\Cheech.And.Chong.3.Nice.Dreams.1981.mkv Cheech.And.Chong.Collection\Cheech.And.Chong.4.Still.Smokin'.1983.mkv Cheech.And.Chong.Collection\Cheech.And.Chong.5.Corsican.Brothers.1984.mkv
For Movies, I like to use the word Collection but it could be [Boxset].
Comment #7 originally posted by Omertron on 2009-02-17T09:47:45.000Z:
No, that sucks more. ;)
YAMJ is currently more or less location agnostic. Video files can be placed pretty much anywhere and it still works. That's the way it should stay. People are never going to go with:-
Aliens.1080p.BluRay.DTS.x264-group/Aliens 1986/Alien 2.mkv
when they could go with:-
{Alien}Alien 2.mkv
It's over complicated and restrictive.
:p
Comment #8 originally posted by Omertron on 2009-02-18T09:53:00.000Z:
nfo method sounds good
Comment #9 originally posted by Omertron on 2009-02-18T13:53:47.000Z:
I'm almost ready to commit my code for this. I did make one slight change to the spec for the XML. Instead of what is listed at the top of this thread, I switched it to:
Is everyone cool with that?
Comment #10 originally posted by Omertron on 2009-02-18T14:13:53.000Z:
I try to avoid xbmc style infos wherever possible. Many of my nfo's simply contain an imdb link. Will there be a filename modification option to indicate sets?
Comment #11 originally posted by Omertron on 2009-02-18T14:37:45.000Z:
Will we be able to set a "set" jpg in the XML? I'd rather have an image that denotes it's a set of movies then just the cover of the first movie. Seems to make more sense to me.
Comment #12 originally posted by Omertron on 2009-02-18T14:47:46.000Z:
+1 on the "set" jpg. Maybe an icon of a series of discs to show in the corner of the poster for whatever jpg the person chooses firstmovie or custom... Like we do for the language or HD...
Comment #13 originally posted by Omertron on 2009-02-18T14:56:53.000Z:
This is similar to # 234 & # 326
Comment #14 originally posted by Omertron on 2009-02-18T15:53:30.000Z:
Issue 234 has been merged into this issue.
Comment #15 originally posted by Omertron on 2009-02-18T15:54:21.000Z:
Issue 326 is dependent on this change, so not quite a duplicate, but issue 234 was. Thanks for spotting that
Comment #16 originally posted by Omertron on 2009-02-18T17:16:20.000Z:
the xml format sounds fine by me...
would also like to echo support for a file name standard for this...i really try to avoid nfo's unless i have to.
Comment #17 originally posted by Omertron on 2009-02-18T18:28:09.000Z:
Issue 245 has been merged into this issue.
Comment #18 originally posted by Omertron on 2009-02-18T18:28:44.000Z:
This should follow the convention with other extras and use square brackets []. I would suggest [SET set name] as this will line up with issue 154
Comment #19 originally posted by Omertron on 2009-02-18T18:46:38.000Z:
Having the ability to edit sets or series using an xml file would appease my comments in issue # 245.
Comment #20 originally posted by Omertron on 2009-02-19T00:23:40.000Z:
@tcpaulh: Yes, I am including support for having the set in the filename. Right now, I'm using the braces like in the
@sirtybio, dd314159: I was thinking about user-specified posters this morning. What should happen if two (or more) movies in
@Stuart: Even if I change to using square brackets, it still won't quite match the convention requested in issue 154. I like the braces better, in the sense that I like having a different flag for [Part1] and {Set name}, plus there could be some ambiguity which syntax was intended. But if you feel strongly, I'll switch.
Comment #21 originally posted by Omertron on 2009-02-19T07:19:32.000Z:
I was thinking that eventually we'd have a standard naming convention for YAMJ specific flags. E.G. [PART1], [EXTRA directors commentary], [TRAILER Theatrical], [SET Star Wars], etc. That way we could probably have a single routine to scan for YAMJ tags and update the movie object appropriately.
Comment #22 originally posted by Omertron on 2009-02-19T12:23:37.000Z:
OK, that's a good idea.
Comment #23 originally posted by Omertron on 2009-02-22T05:08:31.000Z:
I'm fine with using the first (by set order) poster defined for the set. That seems to make the most sense in terms of having a saftey net....though I'd only include it in the first one.
To tie this into the file-name convention...would it make sense to just have a jpg for the set name?
eg:
"{AlienSet-1} Alien.mkv" "{AlienSet-2} Aliens.mkv" "{AlienSet-3} Alien 3.mkv" "{AlienSet-4} Alien Resurrection.mkv" "Alien.jpg" "Aliens.jpg" "Aliens 3.jpg "Alien Resurrection.jpg" "AlienSet.jpg"
It would get a bit confusing for the times the set would match the first movie (Aliens is a great example of this) but if people were to use unique names for the sets...it might allow for the file name functionality to match that of the XML.
Just an idea :)
Comment #24 originally posted by Omertron on 2009-02-23T01:58:17.000Z:
OK, first, the filename convention has been changed (per Stuart) to "Alien [SET Alien].mkv" And actually, you can even do multiple sets (which I didn't intend to support originally), eg: "Alien vs Predator [SET Alien][SET Predator].mkv"
Now, set art is pretty much the only thing holding me back from making a commit for this. (I don't want to commit my code, and then have to make a change that breaks things for anyone who started using the feature.) I've made a few false starts on this already. Because of the way sets work (they're invisible categories), scanning for set art based on the set name doesn't really mesh well with the rest of the way YAMJ does things. Plus there's the issue of where to look for it. Do you search the whole library? Just the directories that any of the files are in? Just the directories that the first file is in? No matter what choice you make, there are some gotchas.
So what I thought about instead was to copy the "fanart" scanner and add a "setart" keyword. So you created a file called "Aliens.setart.jpg" which would attach itself to the set Aliens was in. It just occurred to me that doesn't work if Aliens is in more than one set. D'oh!
So I think I'll go the special naming convention route. For the AlienSet set art, I'll look in all the directories where movies in the AlienSet are located for a file called Set_AlienSet.jpg, and if one exists, use it as the artwork.
Comment #25 originally posted by Omertron on 2009-02-23T03:28:36.000Z:
So if it doesn't find a file, does it just default to using the first movie image?
which is completely fine by me..
and i wouldn't go to crazy worrying about it, not everyone will be happy regardless which way you do it :)
Comment #26 originally posted by Omertron on 2009-02-23T04:04:04.000Z:
Are we still having the choice of using the NFO method? :)
Comment #27 originally posted by Omertron on 2009-02-23T04:18:05.000Z:
Yeah, right now it always uses the poster for the first movie in the set, since it shares the singleSeriesPage implementation. I plan to preserve that as a default behavior if the poster scanner doesn't find anything.
You can associate a movie with a set as described in comment # 9, but I don't like the idea of putting the set poster in the NFO. The poster applies to the set, but the NFO describes a movie, so it doesn't really belong there.
Comment #28 originally posted by Omertron on 2009-02-23T04:21:13.000Z:
Yep, that's cool. Happy to have the separate jpg file for the cover art. Was just hoping we'd still be able to specify the sets within the NFO, rather than editing the file names (which is a chore). Good stuff, thanks :)
Comment #29 originally posted by Omertron on 2009-02-23T12:53:28.000Z:
Sounds like a good plan to me, can't wait to give it a go.
Comment #30 originally posted by Omertron on 2009-02-23T19:55:16.000Z:
I'd still like an icon in the upper right, to show me it's a set, or a mulipart movie or some indication that the single poster on the page represents more than 1 movie/TVshow too. Maybe place the set icon in the lower right so it doesn't interfere with anyone that still wants to use langange/HD/TV icons./// Something like this": http://www.vanderbiltchildrens.com/admin/data_resources/frclib/cds.gif or
Comment #31 originally posted by Omertron on 2009-02-23T21:23:55.000Z:
just found this after i posted a request on the forum, sorry about that...
i would think this would be the best way to name them: Harry Potter {1} Sorcerers Stone VC1 LPCM.m2ts Harry Potter {2} Chamber of Secrets VC1 LPCM.m2ts Harry Potter {3} Prisoner of Azkaban VC1 LPCM.m2ts Harry Potter {4} Goblet of Fire VC1 LPCM.m2ts Harry Potter {5} Order of the Phoenix VC1 LPCM.m2ts
that would sort them properly in yamj and sort properly when viewing in windows.
putting something before the name with { would sort to the top and not be in the H's where i would be looking for it if i need to find it in windows file explorer.
thanks
Comment #32 originally posted by Omertron on 2009-02-24T12:46:42.000Z:
I have made a commit for this, R760. There's at least one bug that I know of -- for some reason, it's not remembering that it already scanned members of a set, but that's mostly harmless. So have at it, and let me know everything else I need to fix. :)
@dd314159: Having an overlay for the set master sounds like a good idea to me.
@digitalman: I think we're trying to avoid making more special characters and special syntax situations. If sort order of the filenames is important to you, name them whatever you want, and use NFO files.
Comment #33 originally posted by Omertron on 2009-02-24T16:03:43.000Z:
Please provide more details here as to what was settled on, and how this is now supposed to be used in regards to
Comment #34 originally posted by Omertron on 2009-02-24T19:44:59.000Z:
I am getting this error: Exception in thread "main" java.lang.StringIndexOutOfBoundsException: String index out of range: 4 at java.lang.String.substring(Unknown Source) at com.moviejukebox.scanner.MovieFilenameScanner.updateSets(MovieFilenameScanner.java:528) at com.moviejukebox.scanner.MovieFilenameScanner.scan(MovieFilenameScanner.java:83) at com.moviejukebox.scanner.MovieDirectoryScanner.scanFile(MovieDirectoryScanner.java:207) at com.moviejukebox.scanner.MovieDirectoryScanner.scanDirectory(MovieDirectoryScanner.java:98) at com.moviejukebox.scanner.MovieDirectoryScanner.scan(MovieDirectoryScanner.java:71) at com.moviejukebox.MovieJukebox.generateLibrary(MovieJukebox.java:328) at com.moviejukebox.MovieJukebox.main(MovieJukebox.java:183)
Comment #35 originally posted by Omertron on 2009-02-24T19:48:39.000Z:
same here. posted over at http://www.networkedmediatank.com/showthread.php?tid=15625&page=15
Comment #36 originally posted by Omertron on 2009-02-24T20:40:32.000Z:
Hah! I bet you have files with [CD1] in the filename, right? I always use "[Part1]", so I didn't notice it. Silly mistake, it'll be fixed as soon as I get home.
Comment #37 originally posted by Omertron on 2009-02-24T20:41:36.000Z:
@garp Did you check out the wiki page? http://code.google.com/p/moviejukebox/wiki/BoxedSets
I should have linked to it in my earlier comment.
Comment #38 originally posted by Omertron on 2009-02-24T20:48:02.000Z:
yep, lots of CD1's and CD2's etc. Glad it's an easy fix :)
Comment #39 originally posted by Omertron on 2009-02-24T21:31:02.000Z:
this may not be related but after changing files to part1 etc I'm now getting a lot of (but not all) errors eg:-
[code]Updating data for: Changeling Failed retreiving imdb rating for movie : tt0824747 java.io.IOException: Server returned HTTP response code: 502 for URL: http://www .imdb.com/title/tt0824747/ at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at sun.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source)
at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Sou
rce) at java.lang.reflect.Constructor.newInstance(Unknown Source) at sun.net.www.protocol.http.HttpURLConnection$6.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at sun.net.www.protocol.http.HttpURLConnection.getChainedException(Unkno wn Source) at sun.net.www.protocol.http.HttpURLConnection.getInputStream(Unknown So urce) at com.moviejukebox.tools.WebBrowser.request(WebBrowser.java:75) at com.moviejukebox.tools.WebBrowser.request(WebBrowser.java:49) at com.moviejukebox.plugin.ImdbPlugin.updateImdbMediaInfo(ImdbPlugin.jav a:233) at com.moviejukebox.plugin.ImdbPlugin.scan(ImdbPlugin.java:60) at com.moviejukebox.plugin.DatabasePluginController.scan(DatabasePluginC ontroller.java:39) at com.moviejukebox.MovieJukebox.updateMovieData(MovieJukebox.java:577) at com.moviejukebox.MovieJukebox.generateLibrary(MovieJukebox.java:341) at com.moviejukebox.MovieJukebox.main(MovieJukebox.java:183) Caused by: java.io.IOException: Server returned HTTP response code: 502 for URL: http://www.imdb.com/title/tt0824747/ at sun.net.www.protocol.http.HttpURLConnection.getInputStream(Unknown So urce) at sun.net.www.protocol.http.HttpURLConnection.getHeaderFields(Unknown S ource) at com.moviejukebox.tools.WebBrowser.readHeader(WebBrowser.java:127) at com.moviejukebox.tools.WebBrowser.request(WebBrowser.java:73) ... 7 more[/code]
Comment #40 originally posted by Omertron on 2009-02-24T23:08:49.000Z:
"Caused by: java.io.IOException: Server returned HTTP response code: 502 for URL: http://www.imdb.com/title/tt0824747/"
A 502 error is a web server error -- it's saying that IMDB failed to respond to the HTTP request. And it's happening before any of the indexing code. I suppose it could be an artifact of the changes I made to MovieFilenameScanner. How, exactly, is Changeling named? If there's an NFO for it, can you attach it? Do you get the error if you scan just the one file? (The trick I use is to make a directory with just a blank text file with the name "Changeling.avi". YAMJ doesn't care whether or not it's really a movie -- it just looks at the extension.)
Oh, and R761 should fix the problem with the index out of bounds for file with "[cdX]" in the name.
Comment #41 originally posted by Omertron on 2009-02-24T23:11:36.000Z:
I'll give it a run as soon as the compiled version is uploaded somewhere :)
Comment #42 originally posted by Omertron on 2009-02-24T23:31:09.000Z:
http://nullptr.merseine.nu/~josh/nmt/yamj-svn-r761.zip
I have a script on my web server that checks to see if there's a new revision every 10 minutes, and if there is, it updates it, builds it, and makes it available for download. You can reference it by revision number (as in the link above), or you can use http://nullptr.merseine.nu/~josh/nmt/yamj-latest.zip which is always the newest build.
Stuart, when am I getting that FTP account? ;-)
Comment #43 originally posted by Omertron on 2009-02-24T23:49:47.000Z:
Need to trap unacceptable characters in windows. M_A_S*H is causing Java to implode when trying to write the .jpg ;). Same problem we've run into a few times in the recent past with dev builds.
Comment #44 originally posted by Omertron on 2009-02-24T23:50:15.000Z:
Spaces seem to be causing a problem here with details page requests returning "Request cannot be processed" on the NMT and "cannot be found" on the PC. html files are stored on NMT with spaces replaced by ANSI code %20.
eg:
Amusement (2008).html cannot be found File is called Amusement%20(2008).html Australia (2008)[part1].html cannot be found File is called Australia%20(2008)[part1].html Black Snake Moan.html cannot be found Black%20Snake%20Moan.html Body of Lies[part1].html cannot be found Body%20of%20Lies[part1].html Casino.Royale.2006[SET Bond Movies].html cannot be found Casino.Royale.2006[SET%20Bond%20Movies].html
Comment #45 originally posted by Omertron on 2009-02-24T23:58:29.000Z:
Ok, I have the following options in .nfo files for the "Back to the Future" movies:
<sets>
<set order="3">Back to the Future Movies</set>
</sets>
With the order replaced as it fits (1, 2, 3). However, in the default skin...i only see back to the future...it works, I can select it and get the detail, but the other two aren't being added to the set. I'm going to try it without the "order" tag now and see if that fixes it.
Comment #46 originally posted by Omertron on 2009-02-25T00:22:25.000Z:
@sirtybio: I hate Windows! :) We need a test harness that actually writes the files instead of just checking what's in memory. I was checking the XML and HTML files -- which are fine. But the jpg, as you noticed, is FUBAR.
I'm having trouble duplicating your BTTF problem. It indexes them correctly for me, with or without the order.
@tcpaulh Damn. That was a regression bug. (I had fixed it, and now it's back.) Double damn.
Comment #47 originally posted by Omertron on 2009-02-25T00:32:32.000Z:
No worries. Really impressed how fast YAMJ is maturing.
Comment #48 originally posted by Omertron on 2009-02-25T00:36:24.000Z:
All part of testing out dev builds! No stress at all man. I'm rebuilding the jukebox from scratch using the default skin now, I'll see if it happens again. If they still don't group, what sort if information should I gather for you? I wasn't seeing the covers for 2 or 3, they just...weren't there...so I'm not sure what I can provide.
Comment #49 originally posted by Omertron on 2009-02-25T00:49:00.000Z:
An interesting question I came up with while waiting to rebuild the library. Is it possible to include series indexes in sets?
As an example, I have a ton of Star Trek movies...and at least 3 of the TV Series.
Using this build, I get a single index page for the series (which is a HUGE
improvement), can you assign a
"Star Trek Movies" -> "Star Trek: Enterprise" -> "Season 1" -> (Season episode list)
Not a big deal, just curious if it would work.
Comment #50 originally posted by Omertron on 2009-02-25T00:50:54.000Z:
OK fellas. Try R764, please. Thanks for being guinea pigs. :)
@sirtybio What are the files named? What's the complete content of the NFO? Here's what I have that's working. I have the files named bttf1.avi, bttf2.avi, and bttf3.avi. The NFO is just:
That's for bttf1.nfo. I've tried mucking with the order (setting them to 1, 2, 3 respectively, setting them all to 1, setting them all to 3, taking it out, etc), and I can't make it break.
Oh, I do have one idea. Is one of the movies named the same as the directory they're in? Because if there's an NFO file named the same as the directory, it gets applied to ALL movies in the directory (so YAMJ sees them all as the same movie). It's supposed to be used for TV series (since all episodes are part of the same season "movie" in YAMJ), but I've had it mess me up when I inadvertantly activated the feature with actual movies.
Original issue 524 created by Omertron on 2009-02-15T15:47:24.000Z:
Currently, there is no way to group movies together into "sets". It would be nice if, instead of having six entries for the Star Wars movies, you could get one entry for the Star Wars set, which takes you to another page that lists the movies in that set. This is very similar to issue # 113, except this would allow the user to specify the groupings.
I envision two mechanisms for controlling set affinity. The simpler is an additional field to the filename: "{Set name[-Order#]} Rest of filename as before".
For example: "{Alien-1} Alien.mkv" "{Alien-2} Aliens.mkv" "{Alien-3} Alien 3.mkv" "{Alien-4} Alien Resurrection.mkv"
The more flexible mechanism would be an additional section for the XBMC-style NFO file. Eg, if you have a file named "Alien vs. Predator.mkv", an "Alien vs. Predator.nfo" file could look like: <movie> <title>Alien vs. Predator</title> ... <sets> <set> <name>Alien</name> <order>5</order> </set> <set> <name>Predator</name> <order>3</order> </set> </sets> </movie>
The order would be optional. Unordered movies are ordered by release date within the set, and they would appear after all movies in the set with an assigned order. Unordered movies with an unknown release date are ordered alphabetically by title, and they appear after movies ordered by release date.