YAMJ / yamj-v2

Yet Another Movie Jukebox (YAMJ) v2
GNU General Public License v3.0
28 stars 11 forks source link

XBMC/nfo dual method allowed in NFO file #600

Closed Omertron closed 9 years ago

Omertron commented 9 years ago

Original issue 601 created by Omertron on 2009-03-09T02:27:01.000Z:

I was looking at the Wiki for NFO files, and noticed that the XBMC standards page at http://xbmc.org/wiki/?title=Import_-_Export_Library#TV_Shows says you can use both XBMC layout AND URL [quote] Video nfo files containing a mix of XML and URL

You can also create nfo files that contain both XML data and an URL. This is useful for instance if you want the entry in your database to have another name than the one officially provided by the scraper.

Example <movie> <title>Sin City (Recut, Extended, Unrated)</title> <runtime>147 min.</runtime> </movie> http://www.imdb.com/title/tt0401792/ [/quote]

I know that we've been telling users that they need to use one or the other method, not both.

Should that be changed?

I find myself wanting to allow both now because I have most of my NFO files that only contain the title and IMDB URL in them. Now I need to add boxet info to some, which means converting them to XBMC standards. It also means adding the IMDB < id > field and commenting out the existing text (which I want to keep). Omertron (Stuart) already created a utility to do this so it's not a huge problem, but extra work either way.

What do the developers think about allowing both formats at the same time?

Omertron commented 9 years ago

Comment #1 originally posted by Omertron on 2009-04-11T17:32:36.000Z:

If we support this, it would mean that the XBMC-style NFO files are no longer guaranteed to be valid XML files, which I think is a bad idea.

Omertron commented 9 years ago

Comment #2 originally posted by Omertron on 2009-04-11T23:51:37.000Z:

Yes I understand that in the long run that it is best to only support XML standard when using the XBMC style.

I'll change the priority to low but leave it for now and review once again later.

Omertron commented 9 years ago

Comment #3 originally posted by Omertron on 2009-04-12T00:05:41.000Z:

I was just looking at the XBMC site's documentation for their NFO files (in relation to some other issue), and I noticed they support having the URL after the XML portion. I still don't like it, though.

Omertron commented 9 years ago

Comment #4 originally posted by Omertron on 2010-02-07T02:42:28.000Z:

My request -- removing.