search

YAMJ / yamj-v2

Yet Another Movie Jukebox (YAMJ) v2
GNU General Public License v3.0
28 stars 11 forks source link

Blood Diamond being picked up as Blood but... #623

Closed Omertron closed 9 years ago

Omertron commented 9 years ago

Original issue 624 created by Omertron on 2009-03-14T00:29:26.000Z:

What steps will reproduce the problem?

  1. Movie added to library named 'Blood Diamond [2006] BLU-RAY.mkv
  2. Run YAMJ r810
  3. look at library

What is the expected output? What do you see instead? Blood Diamond expected in Jukebox under ALL and B. It does not show up at all including any match for "Blood" that it fiends instead.

What version of the product are you using? On what operating system? r810 Vista x64 Ultimate SP1

Please provide any additional information below.

The scanner, even after I use a NFO file, still reports as finding Blood.
When using the NFO, it properly populates the database

Thank you!

Omertron commented 9 years ago

Comment #1 originally posted by Omertron on 2009-03-18T05:18:25.000Z:

It identifies it as Rise (2007) on IMDB. But that's because it's not parsing the filename correctly. From my log: Querying IMDB for http://www.imdb.com/find?q=Blood;s=tt;site=aka Blood: found IMDB match, Rise (2007)

Clearly there's something wrong here...

Omertron commented 9 years ago

Comment #2 originally posted by Omertron on 2009-03-18T13:58:24.000Z:

Diamond is a release group and is in the list of excluded words.

Omertron commented 9 years ago

Comment #3 originally posted by Omertron on 2009-03-18T15:11:14.000Z:

Aha! that's right... so then is keying off on Blood? Interesting ;-)

Omertron commented 9 years ago

Comment #4 originally posted by Omertron on 2009-03-19T03:36:16.000Z:

Can someone tell me if the filename.scanner.skip.keywords property is supposed to be case-sensitive? The default list uses mixed-case, which leads me to believe it is. If we enforce case-sensitivity, this would not have been an issue since the skipped string is "DiAMOND".

Omertron commented 9 years ago

Comment #5 originally posted by Omertron on 2009-03-19T06:24:27.000Z:

I'm not on the dev team, obviously, but my moviejukebox.properties file says:

# comma separated list of case-insensitive keywords to ignore in filenames
filename.scanner.skip.keywords=LIMITED,DiAMOND,AXXO,PUKKA,iDHD,PROPER,REPACK,DSR,STV,UNRATED,RERIP,REMUX

The commented out section seems to imply that they are not currently case sensitive.
Omertron commented 9 years ago

Comment #6 originally posted by Omertron on 2009-03-19T07:23:38.000Z:

Yes the property is case insensitive, I think it's converted to uppercase when checked.

Again, it seems we need to check the scanner words against the title of the movie to see if they are excluded.

Omertron commented 9 years ago

Comment #7 originally posted by Omertron on 2009-03-19T11:10:43.000Z:

Wow. I read the wiki on the property (which doesn't mention case sensitivity), but I didn't think to check the comment in the config file. :)

Well then. I guess this defect is invalid, since YAMJ's behaving as intended, and Manny can get the desired behavior by adjusting a configuration property.

Omertron commented 9 years ago

Comment #8 originally posted by Omertron on 2009-03-19T11:54:47.000Z:

Just a thought, but would it be possible to not skip those keywords if they come before the movie year in the filename.

So Blood.2007.DiAMOND.avi would pickup Rise, while Blood.Diamond.2006.DiAMOND.avi would correctly scan as Blood Diamond.

Omertron commented 9 years ago

Comment #9 originally posted by Omertron on 2009-03-19T12:00:17.000Z:

@azuravian That's basically the gist of this issue: http://code.google.com/p/moviejukebox/issues/detail?id=616

Omertron commented 9 years ago

Comment #10 originally posted by Omertron on 2009-03-19T13:52:04.000Z:

Updated the wiki.

Omertron commented 9 years ago

Comment #11 originally posted by Omertron on 2009-03-19T15:56:43.000Z:

OK, I am confused ;-)

What should I be doing then? I mean I got it to work via NFO, but it seems to be an improper workaround... do I have to do something to my config file?

Thanks guys MG

Omertron commented 9 years ago

Comment #12 originally posted by Omertron on 2009-03-19T16:40:00.000Z:

OK, do I deleted the keyword DiAMOND form the list of excluded keywords and now it picks up Blood Diamond.

So, I am not sure if this is a workaround or a non issue. I thought that Stuart mentioned above that it was not really working properly.

Indeed I think my movie title is correct and that the KEYWORD DiAMOND was intended to remove a release group and not hamper the movie title scanner...

:-)

Thanks

Omertron commented 9 years ago

Comment #13 originally posted by Omertron on 2009-03-19T17:36:51.000Z:

It's not working correctly. The scanner exclusion property (any property in fact) should not detract from the movie title.

However, there will always be a case where the two clash, and in your case, this is one of those. The NFO file method was created for instances such as this, so you can override the scanner with the actual movie.

Glad its working now :)

Omertron commented 9 years ago

Comment #14 originally posted by Omertron on 2009-03-19T18:03:11.000Z:

Yeah, it worked with the NFO and now that I took out DiAMOND from the exclusion list it works great...

LOVE to have workarounds... in my world (Routing and Switching) we live by workarounds to routing issues, ESPECIALLY with EIGRP and BGP ;-)... !!

As always, THANK YOU!

Manny