search

YAMJ / yamj-v2

Yet Another Movie Jukebox (YAMJ) v2
GNU General Public License v3.0
28 stars 11 forks source link

Create "dual language" icon #658

Closed Omertron closed 9 years ago

Omertron commented 9 years ago

Original issue 659 created by Omertron on 2009-03-28T14:51:57.000Z:

The following error message appear during Indexing libraries:

Failed drawing Language logo to thumbnail file: Please check that language specific graphic (Dual Language.png) is in the resources/languages directory.

It looks like files with "dl" inside them are detected as dual language and that png file is missing from the skin resources\languages directory.

I have tested this with 1.0.16 beta release.

Omertron commented 9 years ago

Comment #1 originally posted by Omertron on 2009-04-19T01:44:28.000Z:

This is a harmless message. I suppose the reason there's no dual language icon is, what a dual language icon look like? If anyone wants to design one, I'd be happy to consider including it.

Omertron commented 9 years ago

Comment #2 originally posted by Omertron on 2009-04-19T02:57:12.000Z:

This would be hard since dual language is different for many people. For me that could be English/French, for others English/German. And I would expect that most people would always use the same two. In essence I think the request really refers to using the tag .DL. in the filename.

An idea would be an option to include the language codes, for example: mjb.duallang = "EN,FR" And then YAMJ looks for a custom dual flag image already created for some of the most common combinations: ie look for dl.en.fr.png or YAMJ merges two flags to create a new one and then resizes for standard size. Or it could simply take the left half of one flag and merge to right half of other flag, or it could also stack one on top of the other.

For myself I use .EN-FR. (not a standard) for those few that have 2 audio tracks.

Other than that I will define non-english audio with English subtitles, to include the foreign audio: .FRENCH. .RUSSIAN. .ASIAN. .SPANISH. etc ... again not standard.

Omertron commented 9 years ago

Comment #3 originally posted by Omertron on 2009-04-19T18:22:33.000Z:

sebasttj, Here is an icon I have been using for the Dual case.

Omertron commented 9 years ago

Comment #4 originally posted by Omertron on 2009-04-23T00:56:10.000Z:

What do you guys think?

Omertron commented 9 years ago

Comment #5 originally posted by Omertron on 2009-04-23T01:39:05.000Z:

I see this issue as low priority, unless you come up with a simple way to do this, with minimal coding changes required.

Omertron commented 9 years ago

Comment #6 originally posted by Omertron on 2009-04-23T01:45:07.000Z:

I think it's already supported in the code, we just don't have a DL image in the skins. (Could be wrong -- I'm just going by the error message reported by the OP.)

Omertron commented 9 years ago

Comment #7 originally posted by Omertron on 2009-04-23T05:17:35.000Z:

DL as a language code is included. The problem from our perspective is which languages are part of the dual?

You can either go the route as above and have "Dual" or you (as a user) can concoct a flag with both of the languages in it.

Omertron commented 9 years ago

Comment #8 originally posted by Omertron on 2009-04-23T11:22:33.000Z:

Im happy to just have "Dual", since I mainly care about knowing if there are additional audio tracks. In my case, thats usually EN-ES, but sometimes the film could have ES-FR, or even occasionally an audio commentary from the director has been muxed in. As long as I can see the flag, or a Dual note in the skin specs area... I do see Garps point that some would prefer an explicit listing of the languages involved.

Omertron commented 9 years ago

Comment #9 originally posted by Omertron on 2009-05-27T21:35:56.000Z:

Just add the attached png that paulcito created, so we will not have this error message all the time.

Omertron commented 9 years ago

Comment #10 originally posted by Omertron on 2009-05-28T12:04:05.000Z:

Fixed in r987