search

YAMJ / yamj-v2

Yet Another Movie Jukebox (YAMJ) v2
GNU General Public License v3.0
28 stars 11 forks source link

Rotten Tomatoes Ratings instead of IMDb #905

Closed Omertron closed 9 years ago

Omertron commented 9 years ago

Original issue 906 created by Omertron on 2009-07-13T15:26:49.000Z:

I've seen a thread on the NMT forums that looks at the possibilty of using Rotten Tomatoes ratings instead of IMDb on YAMJ.

I don't know much about coding but there seems to be at least a basic explanation of how this would work in the thread located here - http://networkedmediatank.com/showthread.php?tid=21986

Rotten Tomatoes ratings are more accurate than IMDb, I find. This would be a great option in the moviejukebox.properties files.

Anyone agree?

Omertron commented 9 years ago

Comment #1 originally posted by Omertron on 2009-07-22T07:23:15.000Z:

<empty>

Omertron commented 9 years ago

Comment #2 originally posted by Omertron on 2009-09-12T13:03:22.000Z:

Issue 993 has been merged into this issue.

Omertron commented 9 years ago

Comment #3 originally posted by Omertron on 2011-03-30T14:35:06.000Z:

New thread on the NMT site ( http://www.networkedmediatank.com/showthread.php?tid=51024 ) discussing a new API released by the Rotten Tomatoes team ( http://developer.rottentomatoes.com/ )

Omertron commented 9 years ago

Comment #4 originally posted by Omertron on 2011-04-01T18:05:28.000Z:

There's an enormous amount of people on the NMT forums who are eagerly anticipating this feature. Can't wait!

Omertron commented 9 years ago

Comment #5 originally posted by Omertron on 2011-06-15T06:04:16.000Z:

The API has been done. It's "just" a case of adding it now.

I was thinking that it would just overwrite whatever rating has been currently populated.

Omertron commented 9 years ago

Comment #6 originally posted by Omertron on 2011-06-15T13:08:07.000Z:

Incredible Stuart.. yes the overwrite behaviour you describe is perfect. I'll let some people know, very exciting.

Omertron commented 9 years ago

Comment #7 originally posted by Omertron on 2011-06-15T13:15:59.000Z:

Would it be possible to display both RT and IMDb ratings on the detail page--since they're not always comparable for a given film.

Maybe allow the user to set a default in the moviejukebox.properties for potential rating sorting or index page display.

Omertron commented 9 years ago

Comment #8 originally posted by Omertron on 2011-06-15T13:17:42.000Z:

I agree that it would be better to have IMDb and RT ratings side by side, rather than RT overwriting IMDb.

Omertron commented 9 years ago

Comment #9 originally posted by Omertron on 2011-06-15T13:23:45.000Z:

If people do have the time to implement side by side vs a straight overwrite, I think having the "IMDb" and "RT" text beside each rating to differentiate the source would be ideal.

Omertron commented 9 years ago

Comment #10 originally posted by Omertron on 2011-06-15T13:25:17.000Z:

If I overwrite, you get it now. If I side-by-site you have to wait for skin support.

Omertron commented 9 years ago

Comment #11 originally posted by Omertron on 2011-06-15T13:27:28.000Z:

I say overwrite for now, I'd be thrilled anyhow. Thanks again.

Omertron commented 9 years ago

Comment #12 originally posted by Omertron on 2011-06-15T13:29:53.000Z:

Agreed. Let's make it happen sooner than later. Maybe down the road, there could be some option for using both, once skins catch up.

Omertron commented 9 years ago

Comment #13 originally posted by Omertron on 2011-06-15T13:55:33.000Z:

Maybe this can be my first contribution :)

I'll try and work on side by side support.

I think you should at least add an option to the properties file for the user to set IMDb or RT.

Then I could create a new node, as a secondary rating which would be just NOT the preferred rating source.

After I finish some projects I'll take a look.

Omertron commented 9 years ago

Comment #14 originally posted by Omertron on 2011-06-15T13:58:43.000Z:

Too slow Chris :)

I've decided to implement multi-rating in the movie model. This means that you can choose what rating to use as the main rating, as well as storing all available ratings.

Also you can set the rating to be the average of all ratings, so if you have an IMDB and a RT rating, it'll average out them to give you the combined score.

Skins can still choose to display one or the other as you want

Omertron commented 9 years ago

Comment #15 originally posted by Omertron on 2011-06-15T14:02:40.000Z:

You're all heroes in my books.

Omertron commented 9 years ago

Comment #16 originally posted by Omertron on 2011-06-15T14:06:34.000Z:

Booooo :)

Finally something I felt I could manage haha.

Nice job Stu. So it's just up to the skins now? To decide how to display?

What formula did you use to average the scores? Just multiply IMDb by 10 and average those two percentages?

Omertron commented 9 years ago

Comment #17 originally posted by Omertron on 2011-06-15T14:10:15.000Z:

Every site stores out of 100, so add them up and divide by the number of sites.

Omertron commented 9 years ago

Comment #18 originally posted by Omertron on 2011-06-15T14:59:17.000Z:

This issue was closed by revision r2517.

Omertron commented 9 years ago

Comment #19 originally posted by Omertron on 2011-06-15T15:09:58.000Z:

Check out the new properties http://code.google.com/p/moviejukebox/wiki/PropertiesConfiguration#mjb.rating.source http://code.google.com/p/moviejukebox/wiki/PropertiesConfiguration#Rotten_Tomatoes