YAMJ / yamj-v3

Main Project for YAMJ v3
11 stars 7 forks source link

add awards to the scanner and API #168

Closed jluc2808 closed 9 years ago

jluc2808 commented 9 years ago

add awards to the filescanner, and API for API

modmax commented 9 years ago

I don't think that awards are scanned from the file name ... so this is just a core and api issue.

Omertron commented 9 years ago

Might be in the NFO file too, not sure if Kodi (XBMC) covers this, will need to check with their spec

Omertron commented 9 years ago

My bad, closed wrong issue

modmax commented 9 years ago

My suggestion is: 1.) awards are available for movies and series 2.) Each award consist of 3 fields: awardType (i.e. Academy Awards (based on scanner)), year and award dscription (based on scanner). 3.) if dataitems=awards is added then also the awards fpr the movie/series should be retrieved

What ist intended to list awards, btw. whhat is expected to be returned a.) awart type with year? b:) award type only? c.) award with year and description?

If you want person awards, then a seperate issue should be created, cause that will be to much for this issue. This isseu just handles movie and series awards.

Omertron commented 9 years ago

Have a look at the awards in YAMJv2

Personally I don't care for them as they come from IMDB only

On 27 January 2015 at 12:01, modmax notifications@github.com wrote:

My suggestion is: 1.) awards are available for movies and series 2.) Each award consist of 3 fields: awardType (i.e. Academy Awards (based on scanner)), year and award dscription (based on scanner). 3.) if dataitems=awards is added then also the awards fpr the movie/series should be retrieved

What ist intended to list awards, btw. whhat is expected to be returned a.) awart type with year? b:) award type only? c.) award with year and description?

If you want person awards, then a seperate issue should be created, cause that will be to much for this issue. This isseu just handles movie and series awards.

Reply to this email directly or view it on GitHub https://github.com/YAMJ/yamj-v3/issues/168#issuecomment-71636643.

modmax commented 9 years ago

The awards yan now be scanned and retrieved by the API; right now just fpor allocine:

PreConditions: 1.) the configuration "allocine.movie.awards" is set to true (default: false) 2.) the configuration "allocine.tvshow.awards" is set to true (default: false) 3.) Set videoData/series to UPDATED to force a rescan where the awards will be fetched

API methods: a.) /api/awards/list: This lists all available award (event and category) b.1) videoList --> include=award-7 ... this will include all videos for awards with award id 7 b.2) videoList --> include=award-Golden Globes ... this will include all videos with awards for event "Golden Globes" c.) singe video: dataitems=award ... retrieves also the awards

Omertron commented 9 years ago

I think, like yamjv2, we should have properties that are generic rather than specific to a scraper.

So the above should be "awards.tv" and "awards,movie".

You should then have "allocine.awards" true

This way you can control what plugins get what items for you (you might not like the allocine awards for example)

modmax commented 9 years ago

It's nearly the same, but then you cannot specify exactly what you want.

With your suggestion you could not set: Scrap movie awards from IMDB and series awards from allocine. The idea in YAMJ v2 was mainly ... configure everything as default and let the scanners do the rest ... if the have the infos or not.

But mostly you have your favorite plugin ... one have allocine, the others themovietb and thetvdb as combination. So the users should have the possibility to configure their favorite scanner ...

With complex properties, i.e. to say yamj: scan awards for movies and series ... YES .. but then the allocine scanner says .. NO ... may be frustrating if you dn't know why you have to set this here, and that there ... so easiest way: configure the scanner and tell hm what he shoudl do or not .. and then it's clear, that this gadget is specific to that scanner.

I think t's better that the common yamj settings are effecting all scanners (cause they all yan handle it); but special gadgets should be left to the plugins ...

jluc2808 commented 9 years ago

tested ok