search

YANBForwarder / YANBF

Yet another nds-bootstrap forwarder. Runs from 3DS-mode!
GNU General Public License v2.0
161 stars 4 forks source link

Release files are not +x'd for macOS and Linux #11

Closed samualtnorman closed 2 years ago

samualtnorman commented 2 years ago

otherwise, the YANBF Generator GUI just hangs forever on the first game without any sign of any error error handling would be nice too, but that's probably a different issue

ty for the cool tool though :^)

lifehackerhansol commented 2 years ago

otherwise, the YANBF Generator GUI just hangs forever on the first game without any sign of any error error handling would be nice too, but that's probably a different issue

ty for the cool tool though :^)

I... already did? At least it should be doing that within GitHub Actions itself.

This is actually a bug that needs to be fixed. Thanks for reporting.

lifehackerhansol commented 2 years ago

@samualtnorman can you please check if this is properly chmodded? https://nightly.link/lifehackerhansol/YANBF/workflows/nightly/main

samualtnorman commented 2 years ago

still getting zsh: permission denied: ./generator are you sure the "is executable" flag even survives being zipped and unzipped?

lifehackerhansol commented 2 years ago

My guess is that it isn't.

Which is a problem. How do I make this simple for the average user lol. I literally just removed Python in the hopes that it would mean less CLI...

samualtnorman commented 2 years ago

the GUI didn't require me to change any permissions on it, so maybe your best bet is to get the GUI tool to chmod +x the files on startup

Yrouel commented 2 years ago

What are you using to build the final release? I just tried and the zip utility on mac does preserve the unix permissions upon unzipping. Perhaps see if you can change utility on your side or find the option to specifically preserve the flags

lifehackerhansol commented 2 years ago

I directly upload to GitHub via its API. This is not really a ZIP issue but rather a GitHub issue.

I can double zip the releases, I guess. That shouldn't be that difficult for people, right?

I'm in the process of rewriting YANBF in a completely different language so I'll think about it after I get that finished up.

lifehackerhansol commented 2 years ago

This was fixed by double zipping the release for macOS and Linux.