YANBForwarder / YANBF

Yet another nds-bootstrap forwarder. Runs from 3DS-mode!
GNU General Public License v2.0
159 stars 4 forks source link

Possible solution for rom hacks sharing same ID of original rom but with different custom banner: pass the ball to the user #21

Open Yrouel opened 2 years ago

Yrouel commented 2 years ago

I just made a banner for both New Super Mario Bros. and its rom hack Newer Super Mario Bros. DS the latter however shares the same ID of the original rom so the generator wouldn't be able to differentiate. My proposal for these specific somewhat edge cases would be to add the other assets in a folder called ID.1 (in this case it would've been A2D.1) and if the generator sees the presence of multiple assets it can just pop the question to the user. Something like "it seems this rom has multiple assets available, it typically means the alternate asset is for a rom hack, if you are unsure proceed with the default"

I think it's acceptable to just ask the user given the niche nature of this issue

lifehackerhansol commented 2 years ago

This isn't a bad idea. I'll think about this. I'm not too certain how I should implement it server-side.