YARC-Official / YARG

YARG (a.k.a. Yet Another Rhythm Game) is a free, open-source, plastic guitar game that is still in development. It supports guitar (five fret), drums (plastic or e-kit), vocals, pro-guitar, and more!
https://yarg.in/
GNU Lesser General Public License v3.0
735 stars 162 forks source link

Drums Overhit & Velocity Threshold #243

Open EmperorJacoba opened 1 year ago

EmperorJacoba commented 1 year ago

image

Drums should have options to set overhit & velocity thresholds when setting up drum pads (like in clone hero). Additionally, a test velocity function would be nice to go with it.

(Personal note: My red pad overhits when I hit my yellow cymbal and vice versa, so it is literally impossible for me to get a streak when playing. This config menu is the only thing keeping me from getting 3 stars for every song lol)

TheNathannator commented 1 year ago

Some general input debounce functionality was implemented recently which should cover the overhit threshold part. Velocity threshold and testing could also be covered in a way that other devices can benefit from, all inputs are handled with no actual knowledge about the device they come from so it's actually easier to do it that way lol

I can probably look into getting this done relatively soon, will let you know when that happens!

TheNathannator commented 9 months ago

Apologies for the delayed response!

Velocity threshold has been implemented for a long time now via the Press Point calibration for button bindings, and more recently given a more proper display meant specifically for MIDI controls.

Overhit threshold has been expanded on with a new debounce that applies to all controls on a binding at once (i.e. ignoring overhits between multiple zones on a single pad). The only level of protection left to implement is a crosstalk threshold (ignoring overhits between different pads/cymbals).