search

YARC-Official / YARG

YARG (a.k.a. Yet Another Rhythm Game) is a free, open-source, plastic guitar game that is still in development. It supports guitar (five fret), drums (plastic or e-kit), vocals, pro-guitar, and more!
https://yarg.in/
GNU Lesser General Public License v3.0
742 stars 162 forks source link

[Nightly] Buttons held on a pause will remain held until pressed again #634

Closed pul53gh closed 9 months ago

pul53gh commented 10 months ago

In both practice and quickplay, on both square and circle theme, if you hold frets while pausing, those buttons will remain held after unpausing until they are pressed again

Clips: Practice, Circle Theme Practice, Square Theme Quickplay, Square Theme

It's not just cosmetic, they're functionally held down too. You can see in this clip I can't hit the gr/gy (or i guess ro/ry) chords (I strummed them too, not a ghosting problem), but I did hit that r/b (or o/g) chord at the end even though I wasn't holding blue(green), just red(orange).

Evidence of functionality

(sorry I didn't have a hand cam set up or anything, just trust me I promise I wasn't holding the buttons lol)

pul53gh commented 10 months ago

I don't think the fact it's Windows matters much lol, seem like predominantly a game issue. Mb

TheNathannator commented 10 months ago

This is a known issue, it's because inputs are not forwarded to the engine while paused, so any fret releases that occur aren't processed. Surprisingly wasn't on our issue tracker yet, added it here.

TheNathannator commented 9 months ago

This issue has now been fixed for a good bit, apologies for the late response!

pul53gh commented 9 months ago

No problem lol, good that it’s fixed.

On Thu, Feb 8, 2024 at 1:49 AM Nathan @.***> wrote:

This issue has now been fixed for a good bit, apologies for the late response!

— Reply to this email directly, view it on GitHub https://github.com/YARC-Official/YARG/issues/634#issuecomment-1933453120, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR7FTIAZV5PONX5RWAXVYK3YSRYOTAVCNFSM6AAAAABBDNGYNWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZTGQ2TGMJSGA . You are receiving this because you authored the thread.Message ID: @.***>