search

YARC-Official / YARG

YARG (a.k.a. Yet Another Rhythm Game) is a free, open-source, plastic guitar game that is still in development. It supports guitar (five fret), drums (plastic or e-kit), vocals, pro-guitar, and more!
https://yarg.in/
GNU Lesser General Public License v3.0
688 stars 152 forks source link

Blue toms not converted correctly in some Guitar Hero drum charts #734

Open iceypotato opened 4 months ago

iceypotato commented 4 months ago

I do not know if this is already an issue, but while playing 4 lane drums for certain guitar hero songs, I noticed blue cymbals being used for blue toms. One example is when playing Psychosocial in the Psycho Riff 2 section. If the user was playing in 5 lane mode, then the blue toms would be turned into the orange cymbal.

When doing some more experimentation, it could probably have something to do with songs with a double kick. I noticed that in Hot for Teacher from the GHWT game, the blue toms were converted correctly.

Screenshot 2024-04-06 100752

iceypotato commented 1 month ago

Update: I discovered that this issue happens when all of the difficulties are charted out, which means that in the MIDI file, C4-F4, C5-F5, C6-F6, and B6-F7 have notes in them.