search

YARC-Official / YARG

YARG (a.k.a. Yet Another Rhythm Game) is a free, open-source, plastic guitar game that is still in development. It supports guitar (five fret), drums (plastic or e-kit), vocals, pro-guitar, and more!
https://yarg.in/
GNU Lesser General Public License v3.0
686 stars 151 forks source link

Pro Drum Navigation Not Working Within Search Interface #749

Open StudioKraft opened 4 months ago

StudioKraft commented 4 months ago

I am currently playing YARG using an electronic drum kit connected via the MadCatz MIDI controller for PS3. This all works well, and I can use the drum kit to navigate most of the YARG interface. However, when I use the computer keyboard to search for a particular song, this ability to navigate with the drum set stops functioning, and I need to use a mouse to select the correct song from the search results.

When I return to the main music library interface from the Search, the drum navigation works again.

Actual Result: I am not able to use drums to navigate the Search interface

Expected Result: I should be able to select a song from the Search Results interface using the drums as navigation

Steps to Reproduce: Using an electronic drum kit and the MadCatz PS3 MIDI interface, configure a profile to use the drum set. From the main Song Library interface, use the Search feature to locate a song and attempt to select it from the results using only the drum kit as navigation.

YARG Version: 0.12.3 OS: Windows 11

StudioKraft commented 3 months ago

As a follow up, I experimented a bit more tonight and discovered what was happening. I would use my keyboard/mouse to select the search box, type in the search term and then expect to be able to cycle through the results by using the drums.

I first have to click out of the search box and then the navigation works as expected.

EliteAsian123 commented 3 months ago

Hi, sorry for the late response.

This is actually due to a limitation with how using your computer keyboard as a guitar works in this game. Let's say you bind A to green, which, when pressed, goes into the song you are selecting. If for example, you searched "Sweet Home Alabama" in the search bar, you'd have to press A to fully search this song. The problem is, you can't because in this case, it'd just make you go right into the song, so "Sweet Home" is as far as you'd be able to get.

To solve this, when focused on an input box, the game disables all menu navigation. This works fine for computer keyboard users, however, it doesn't make much sense for players on, in your example, an ekit. Ideally, we'd only make this happen when your keyboard is being used alongside a profile, however, we are yet to implement this fix at this moment.

Sorry for the inconvenience!

StudioKraft commented 3 months ago

Howdy, thanks for the response! This limitation is completely understandable and I felt a bit of an idiot when I finally realized what was happening :)

Yes, having the fix implemented to allow for navigation when using an ekit would be great but I understand it is "minor" compared to the rest of the Roadmap.

EliteAsian123 commented 3 months ago

No worries! Thanks for the understanding.