search

YARC-Official / YARG

YARG (a.k.a. Yet Another Rhythm Game) is a free, open-source, plastic guitar game that is still in development. It supports guitar (five fret), drums (plastic or e-kit), vocals, pro-guitar, and more!
https://yarg.in/
GNU Lesser General Public License v3.0
692 stars 151 forks source link

Star Power phrases are not present on Rock Band charts in .sng format #822

Open AlenaEK opened 1 month ago

AlenaEK commented 1 month ago

Charts from Rock Band don't have their allocated SP phrases when in .sng format. I can only speculate that the game isn't properly reading/unpacking the .sng files. Guitar Hero and custom charts work fine, and switching over to Clone Hero, this issue isn't present.

sonicfind commented 1 month ago

It's actually the .sng that's the issue. If you open the file in an hex editor, you can probably find a string in the metadata section named multiplier_note. That modifier tells the parser what midi value maps to SP/overdrive phrases. When an .ini file doesn't explicitly specify that value, a parser should assume the default value of 116. The problem lies in the sng pack tool just filling in unspecified integer modifiers with 0 - which of course does not line up with the actual file. A fixed version of the tool exists, I believe, but enchorus may not use it yet.

sonicfind commented 1 month ago

Now could we apply a workaround? yes, but I'd rather incentivize the source to fix the bigger issue first.

TheNathannator commented 1 month ago

I made a PR to fix this issue in the tool months ago which got merged, but there has yet to be a new release for it.

(Unfortunately seems to be a recurring pattern for the CH devs; critical issues never given immediate releases because of scope creep involving other issues and features. I can't say we're immune to it either, but we certainly try to keep it under control lol)

TheNathannator commented 1 month ago

A new SngCli release is out, re-converting the songs from their original source files should fix the issue. https://github.com/mdsitton/SngFileFormat/releases/tag/v0.3.0