search

YARC-Official / YARG

YARG (a.k.a. Yet Another Rhythm Game) is a free, open-source, plastic guitar game that is still in development. It supports guitar (five fret), drums (plastic or e-kit), vocals, pro-guitar, and more!
https://yarg.in/
GNU Lesser General Public License v3.0
746 stars 168 forks source link

Whammy FX #846

Closed jbienz closed 3 months ago

jbienz commented 3 months ago

This PR replaces #812 because changes were getting difficult to follow due to merge rather than rebase.

This PR depends on YARG.Core PR 192.

Whammy

I have done my best to incorporate the changes requested by @sonicfind. This includes making sure the effect is also applied to the reverb channel.

Having said that, I honestly still don't fully follow the logic regarding user sharing of stems. I would like to request either:

  1. We merge this feature as-is since its experimental anyway and we can add better handling for instrument sharing later.
  2. @sonicfind, @TheNathannator and I have a voice chat on Discord to help me better understand the request and implementation.
jbienz commented 3 months ago

@TheNathannator I believe all of your requests have been addressed at this point. Please let me know if this can be merged, and thank you again for taking the time to review!

TheNathannator commented 3 months ago

Merged via #855.