YARC-Official / YARG

YARG (a.k.a. Yet Another Rhythm Game) is a free, open-source, plastic guitar game that is still in development. It supports guitar (five fret), drums (plastic or e-kit), vocals, pro-guitar, and more!
https://yarg.in/
GNU Lesser General Public License v3.0
746 stars 168 forks source link

Fix vocal particle colours being blue for HARM2/HARM3 notes #851

Closed thomeval closed 3 months ago

thomeval commented 3 months ago

This PR is to fix the vocal particle colours always being rendered blue, regardless of whether they are solo, HARM1 (blue), HARM2 (red), or HARM3 (yellow).

vocalParticleColours

Note to the reviewer: This implementation matches the implementation for colouring the vocal notes themselves, which was clearly marked as a temporary solution (see VocalTrack.cs). As such, the hard-coded colour set should be replaced with colour profiles for vocals later on.