search

YARC-Official / YARG

YARG (a.k.a. Yet Another Rhythm Game) is a free, open-source, plastic guitar game that is still in development. It supports guitar (five fret), drums (plastic or e-kit), vocals, pro-guitar, and more!
https://yarg.in/
GNU Lesser General Public License v3.0
746 stars 168 forks source link

Stem-muting, countdown, and notification bugfixes #866

Closed Purplo-cf closed 2 months ago

Purplo-cf commented 3 months ago

-Fix for stem-muting while SP reverb is in the process of fading in or out -Fix for countdowns appearing right before the start of a practice section where the earlier notes in the chart are artificially removed -Added countdowns back into the vocal track prefab after they were taken out -Fixed TrackView notifications not appearing by re-checking the box that makes them active by default.

This is a modified version of my PR from last month, rebased to the latest changes. I saw that Nathan fixed vocal range changes in practice mode so I took that out.

Regarding the practice mode countdown fix - I changed how it's structured in Unity so that countdowns are active by default with an alpha of 0 to keep them hidden. This way, Awake() is called at the start of a song and the script can detect if it's in practice mode.

Purplo-cf commented 2 months ago

Reference for @sonicfind 's thoughts on the stem muting fix. EA was looking additional input on the last version of this PR https://discord.com/channels/1086048856678084609/1086052453801283624/1274528287548506165

Purplo-cf commented 2 months ago

Braces added and rebased to the latest changes!