YARC-Official / YARG

YARG (a.k.a. Yet Another Rhythm Game) is a free, open-source, plastic guitar game that is still in development. It supports guitar (five fret), drums (plastic or e-kit), vocals, pro-guitar, and more!
https://yarg.in/
GNU Lesser General Public License v3.0
746 stars 166 forks source link

Band Streaks #916

Open thomeval opened 1 week ago

thomeval commented 1 week ago

This introduces a Band Streak (Combo) counter to YARG, which is displayed underneath the Score Box during gameplay. Although the total Band Streak was previously tracked internally, this code has been reworked and expanded.

image

Band Streaks can be enabled in the Experimental Settings menu. Three modes are available:

All instruments should be supported, although vocals requires special consideration:

To make room for the Band Streak counter, this PR also moves the entire score box up, closer to the vocal highway. This improves, but does not eliminate, issues such as this one on Discord

The graphic for the band streak box is temporary, and an update for it is "Planned".

Note for the reviewer: In the current implementation, much of the streak counting logic resides in the YARG codebase, which is not ideal. Although it would make sense to have this in YARG.Core instead, its infrastructure doesn't really support this yet. We may want to revisit this once Unison Phrases are added to the game.

Requires YARG.Core PR https://github.com/YARC-Official/YARG.Core/pull/223

EliteAsian123 commented 14 hours ago

Hello, thanks for the PR. I'm talking to Kadu about the art side of the PR, so I'll keep you updated on how we'll go about it!