search

YC-Michael / pe

0 stars 0 forks source link

multiple return and method call in same activation bar #12

Open YC-Michael opened 1 year ago

YC-Michael commented 1 year ago

image.png

For the sequence diagram on page 11, activation bar should end on the annotated red line and a new activation bar should start on the blue line.

nus-pe-bot commented 1 year ago

Team's Response

The "delete" is a deletion from Duke to destroy the instance of the Command class as shown on the module website.

image.png

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Wrong method arrows in UML diagram of DG

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

In the Manager section of the DeveloperGuide, there is a method invocation arrow pointed to the end of the activation bar for :Command:

ArrowBug1.png

This doesn't make sense since no method can be called on :Command if it's already getting destroyed(activation bar reaches the cross immediately after the method call arrow).

The severity is low not verylow since this is not cosmetic, but an actual error in the use of UML notation.

[original: nus-cs2113-AY2223S2/pe-interim#1027] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

The "delete" is not a method but a deletion from Duke to destroy the instance of the Command class as shown on the module website.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: Activation bar should end at the red annotation regardless.

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** This is an actual error in UML notation.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]