YC / another_authenticator

A two-factor authentication app built with Flutter.
MIT License
44 stars 13 forks source link

flutter upgrade version #12

Closed bhargavraviya closed 1 month ago

bhargavraviya commented 1 month ago

Flutter Upgrade from scratch

please check it and merge @YC

YC commented 1 month ago

Hi @bhargavraviya, thanks for your PR. While I agree with most of the changes, I would prefer to not review nor accept this in one single PR, given that it touches multiple separate concerns at once (e.g. refactoring, removal of ios, changes to android packaging, changes to flutter packages).

If you're okay with splitting this into multiple PRs, I'd be more than happy to review them separately. In this case, I'd welcome separate PRs for:

Otherwise, I'd be happy to integrate your changes through a set of commits (giving you credit for the changes as co-contributor).

Happy to discuss further!

YC commented 1 month ago

Thanks again. Moving reviews to #15 and #16.