Closed rezaali closed 10 years ago
םץץץ ץידים לשפץ ץ פתחת תל פ ך פ"תפ!םץ !!ץממ מ תלפך,פפ,לפפתפפפךיךפ ףפפ ם לפפתפפפךיךפרבלהםפ"ת?..פ"תלט תללך On Jul 5, 2014 12:21 AM, "Reza Ali" notifications@github.com wrote:
You can merge this Pull Request by running
git pull https://github.com/rezaali/ofxTimeline feature-getTimeDomainSamplesFromAudioTrack
Or view, comment on, or merge it at:
https://github.com/YCAMInterlab/ofxTimeline/pull/110 Commit Summary
- added ability to get time domain samples
- removed commenting of runWindow in ofOpenALSoundPlayer_TimelineAdditions
File Changes
- M libs/ofOpenALSoundPlayer_TimelineAdditions/src/ofOpenALSoundPlayer_TimelineAdditions.cpp https://github.com/YCAMInterlab/ofxTimeline/pull/110/files#diff-0 (59)
- M libs/ofOpenALSoundPlayer_TimelineAdditions/src/ofOpenALSoundPlayer_TimelineAdditions.h https://github.com/YCAMInterlab/ofxTimeline/pull/110/files#diff-1 (7)
- M src/ofxTLAudioTrack.cpp https://github.com/YCAMInterlab/ofxTimeline/pull/110/files#diff-2 (22)
- M src/ofxTLAudioTrack.h https://github.com/YCAMInterlab/ofxTimeline/pull/110/files#diff-3 (6)
- M src/ofxTLCameraTrack.cpp https://github.com/YCAMInterlab/ofxTimeline/pull/110/files#diff-4 (2)
- M src/ofxTimeline.h https://github.com/YCAMInterlab/ofxTimeline/pull/110/files#diff-5 (1)
Patch Links:
- https://github.com/YCAMInterlab/ofxTimeline/pull/110.patch
- https://github.com/YCAMInterlab/ofxTimeline/pull/110.diff
— Reply to this email directly or view it on GitHub https://github.com/YCAMInterlab/ofxTimeline/pull/110.
one little nit pick about redundancy is all but i'm merging this anyway, looks good!