YCloudYUSA / yusaopeny

YMCA’s Website Service. See README.md below
https://ds-docs.y.org/
GNU General Public License v3.0
6 stars 10 forks source link

feat: introduce diff module #110

Closed podarok closed 1 year ago

podarok commented 1 year ago

Original Issue, this PR is going to fix: https://yusaslackinstance.slack.com/archives/C03E6SQQ0Q5/p1693238759352319?thread_ts=1693235674.555889&cid=C03E6SQQ0Q5

Make sure these boxes are checked before asking for review of your pull request - thank you!

If there is a new feature or this is a bug fix - use 9.x-2.x branch. We'll tag for release if the bug is critical asap or tag for release next bug fix release until critical issue arrived.

Steps for review

General checks

Thank you for your contribution!

ciboxbot commented 1 year ago

Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4357/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4357/install.php

froboy commented 1 year ago

@podarok this should have been added with https://github.com/open-y-subprojects/openy_features/pull/67/files. I think I forgot the version bump.

podarok commented 1 year ago

@podarok this should have been added with https://github.com/open-y-subprojects/openy_features/pull/67/files. I think I forgot the version bump.

see above commit, true

ciboxbot commented 1 year ago

YMCA Website Services Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4357/

ciboxbot commented 1 year ago

Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4358/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4358/install.php

ciboxbot commented 1 year ago

YMCA Website Services Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4358/

froboy commented 1 year ago

It looks like http://openy.cibox.tools:8081/view/GITHUB/job/INSTALL_PROFILE/2143/console is failing due to possibly an order of operations issue. I'm assuming openy_features might get installed too late? Checking

podarok commented 1 year ago

It looks like http://openy.cibox.tools:8081/view/GITHUB/job/INSTALL_PROFILE/2143/console is failing due to possibly an order of operations issue. I'm assuming openy_features might get installed too late? Checking

You need to make some module depends from diff or add diff to openy.info.yml as default depedency ( no ), or better add it to some package we do install

froboy commented 1 year ago

@podarok ok, the above PR should resolve it. once it's merged and tagged I'll retest. Thanks.