feat: Add responsive favicon support - Githubissues

YCloudYUSA / yusaopeny

YMCA’s Website Service. See README.md below

https://ds-docs.y.org/

GNU General Public License v3.0

6 stars 9 forks source link

feat: Add responsive favicon support #157

Closed david-storm closed 6 months ago

david-storm commented 7 months ago

Original Issue, this PR is going to fix: https://yusa.atlassian.net/browse/DS-1287

Make sure these boxes are checked before asking for review of your pull request - thank you!

If there is a new feature or this is a bug fix - use main branch. We'll tag for release if the bug is critical ASAP or tag for release next bug fix release until the critical issue arrives.

Steps for review

[ ] Please provide steps for review here.

General checks

[ ] All coding styles are fulfilled and there are no any issues reported by CodeSniffer. See Code of Conduct.
[ ] Try to use Conventional commit messages accordingly to the standard https://www.conventionalcommits.org/en/v1.0.0/#specification
[ ] Documentation has been updated according to PR changes.
[ ] Steps for review have been provided according to PR changes.
[ ] Make sure you've provided all necessary hook_update_N to support upgrade path.
[ ] Make sure your git email is associated with an account on drupal.org, otherwise, you won't get commits there.
[ ] If you would like to get credits on drupal.org, check documentation.

Thank you for your contribution!

ciboxbot commented 7 months ago

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

podarok commented 7 months ago

ok to test

ciboxbot commented 7 months ago

Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4591/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4591/install.php

ciboxbot commented 7 months ago

YMCA Website Services Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4591/

podarok commented 7 months ago

retest this please

ciboxbot commented 7 months ago

Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4594/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4594/install.php

ciboxbot commented 7 months ago

YMCA Website Services Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4594/

ciboxbot commented 7 months ago

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4591/

ciboxbot commented 7 months ago

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4594/

ciboxbot commented 6 months ago

Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4597/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4597/install.php

ciboxbot commented 6 months ago

YMCA Website Services Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4597/

ciboxbot commented 6 months ago

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4597/

podarok commented 6 months ago

retest this please

ciboxbot commented 6 months ago

Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4598/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4598/install.php

ciboxbot commented 6 months ago

YMCA Website Services Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4598/

ciboxbot commented 6 months ago

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4598/

podarok commented 6 months ago

Does work

Thank you