fix: Update paths for webmanifest and add svg. - Githubissues

YCloudYUSA / yusaopeny

YMCA’s Website Service. See README.md below

https://ds-docs.y.org/

GNU General Public License v3.0

6 stars 9 forks source link

fix: Update paths for webmanifest and add svg. #167

Closed froboy closed 5 months ago

froboy commented 5 months ago

https://yusa.atlassian.net/browse/DS-1287

Checker failed a couple places. Cleaning those up. I think that’s as good as we’re going to be able to do.

the hardcoded paths won’t work for the builds as they’re in subdomains, but they will work in most other sites.
browserconfig.xml isn’t detected at the root path, but I’ve added an entry which should get rewritten with the configured path so it’s found.
I added an SVG favicon which is now supported as well.

Steps for review

[ ] Check at https://realfavicongenerator.net/favicon_checker

General checks

[ ] All coding styles are fulfilled and there are no any issues reported by CodeSniffer. See Code of Conduct.
[ ] Try to use Conventional commit messages accordingly to the standard https://www.conventionalcommits.org/en/v1.0.0/#specification
[ ] Documentation has been updated according to PR changes.
[ ] Steps for review have been provided according to PR changes.
[ ] Make sure you've provided all necessary hook_update_N to support upgrade path.
[ ] Make sure your git email is associated with an account on drupal.org, otherwise, you won't get commits there.
[ ] If you would like to get credits on drupal.org, check documentation.

Thank you for your contribution!

froboy commented 5 months ago

ok to test

ciboxbot commented 5 months ago

Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4674/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4674/install.php

ciboxbot commented 5 months ago

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4674/

froboy commented 5 months ago

retest this please

ciboxbot commented 5 months ago

Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4675/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4675/install.php

ciboxbot commented 5 months ago

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4675/

froboy commented 5 months ago

retest this please

ciboxbot commented 5 months ago

Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4679/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4679/install.php

ciboxbot commented 5 months ago

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4679/

ciboxbot commented 5 months ago

Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4680/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4680/install.php

ciboxbot commented 5 months ago

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4680/