YCloudYUSA / yusaopeny

YMCA’s Website Service. See README.md below
https://ds-docs.y.org/
GNU General Public License v3.0
6 stars 9 forks source link

feat: Bump openy_repeat #174

Closed podarok closed 4 months ago

podarok commented 4 months ago

Discussion: https://yusaslackinstance.slack.com/archives/C03E6SQQ0Q5/p1713195433546449

Original Issue, this PR is going to fix: REPLACE WITH A LINK TO ISSUE ( publicly available )

Make sure these boxes are checked before asking for review of your pull request - thank you!

If there is a new feature or this is a bug fix - use main branch. We'll tag for release if the bug is critical ASAP or tag for release next bug fix release until the critical issue arrives.

Steps for review

General checks

Thank you for your contribution!

ciboxbot commented 4 months ago

Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4713/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4713/install.php

ciboxbot commented 4 months ago

YMCA Website Services Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4713/

ciboxbot commented 4 months ago

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4713/

carolpettirossi commented 4 months ago

To validate this:

  1. Enable the module "Y Layout Builder - Repeat Schedules"
  2. Create a new Landing Page (Layout Builder)
  3. Click to "Add a block" to a section
  4. Add the block called "Repeat (Group) Schedules"
  5. Configure as you would configure the Repeat Schedules paragraph in the old Landing Page approach
  6. Add the block
  7. Save the Landing Page (Layout Builder)
  8. Create a new Landing Page (the old one)
  9. In the content are place the Repeat Schedules paragraph. use the same config as you used in the LB block
  10. Save the Landing Page
  11. Test the Group Schedules widget and make sure it works the same as Group Schedules paragraph in the old Landing Page.
ciboxbot commented 4 months ago

Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4735/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4735/install.php

ciboxbot commented 4 months ago

YMCA Website Services Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4735/

ciboxbot commented 4 months ago

Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4738/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4738/install.php

ciboxbot commented 4 months ago

YMCA Website Services Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4738/

ciboxbot commented 4 months ago

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4735/

ciboxbot commented 4 months ago

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4738/

AnastasiiaPys commented 4 months ago

retest this please

ciboxbot commented 4 months ago

Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4739/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4739/install.php

ciboxbot commented 4 months ago

YMCA Website Services Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4739/

ciboxbot commented 4 months ago

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4739/

AnastasiiaPys commented 4 months ago

retest this please

ciboxbot commented 4 months ago

Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4741/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4741/install.php

ciboxbot commented 4 months ago

YMCA Website Services Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4741/

ciboxbot commented 4 months ago

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4741/

AnastasiiaPys commented 4 months ago

Issues that were found during testing:

  1. Register now button is too big image

  2. Home Branch modal is broken on the page with Repeat Schedules block image

  3. Menu is broken on the page with Repeat Schedules block on the Iphone 13 Pro https://github.com/YCloudYUSA/yusaopeny/assets/76169576/2b65da4b-25dd-4fb1-ad21-fd1e37901309

  4. The user can't close Filters section on the Schedules page on tablet https://github.com/YCloudYUSA/yusaopeny/assets/76169576/bd823781-5df2-4536-b167-87f08c84ae43

  5. Refine results accordion is different on the mobile devices image

image

  1. Placeholder of the Schedules block isn't visible image
  2. Titles of the fields are cropped image
rollki commented 4 months ago

retest this please

ciboxbot commented 4 months ago

Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4743/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4743/install.php

ciboxbot commented 4 months ago

YMCA Website Services Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4743/

ciboxbot commented 4 months ago

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4743/