search

YCloudYUSA / yusaopeny_gated_content

Y USA Virtual YMCA
https://ds.ymca.org
GNU General Public License v3.0
2 stars 8 forks source link

Fixed the top menu space css issue. #67

Closed kairamkondarajesh closed 1 year ago

kairamkondarajesh commented 1 year ago

Drupal version: 9.5.11 PHP version: 8.1 yusaopeny_gated_content: 1.8.6 yusaopeny: 9.2.13.0

Issue : Observed that top menu is complete hidden for admin user and showing for member users.

kairamkondarajesh commented 1 year ago

I'm typically very against using !important to solve a problem, but you're not the first one to do it here, so I'm letting it slide with a 😬 because untangling includes is like trying to pull the bottom out of a house of cards.

This doesn't fix the case where the menu toolbar is closed. On line 61, we also need an important here:

        @include carnation_median(top, calc(130px + 40px) !important, calc(78px + 39px));

I have updated the code as per your requested change, Please review.

froboy commented 1 year ago

@podarok this looks good to go.