search

YF-GoogleCodeBackups / https-finder

Automatically exported from code.google.com/p/https-finder
0 stars 0 forks source link

Clicking on 'about' links appear to replace all tabs with the target page (Done, will be in next release) #28

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Open Addons page and goto Options for HTTPS-Finder
2. Click the 'here' link at the bottom of the Options dialog

What is the expected output? What do you see instead?
Help page should open in a new tab in the current FF window; instead it either 
opens in a new window, or it replaces the current tabs with the help page -- 
either way I cannot get back to the previous tabs

What version of the product are you using? On what operating system?
Firefox 4.01 on Windows XP SP3

Please provide any additional information below.

Original issue reported on code.google.com by jimbobmc...@googlemail.com on 2 Jun 2011 at 11:50

GoogleCodeExporter commented 8 years ago 
The code should only open a new window with one tab (the code is 
'window.open('http://someurl.com')). If it replaced your other tabs, I'm not 
sure why/how that happened - sorry.

In any case, I made the fix so that pages add a tab to the current window 
(underneath the modal preference window).

The one I'm going to leave is on the rule preview - it opens instructions in a 
separate window so the user can look through them without closing the rule 
preview window (then to make a rule they'd have to manually edit the URL and 
re-detect).

The fix is made in my current development build, and will be in the next 
release.

Original comment by jacobsK...@gmail.com on 3 Jun 2011 at 3:38

GoogleCodeExporter commented 8 years ago 
See fix here: 
https://code.google.com/p/https-finder/downloads/detail?name=httpsfinder073d1.xp
i&can=2&q=#makechanges

Leaving open since this isn't in an official release yet.

Original comment by jacobsK...@gmail.com on 21 Jul 2011 at 8:27

GoogleCodeExporter commented 8 years ago

Original comment by jacobsK...@gmail.com on 22 Sep 2011 at 3:39