YF-GoogleCodeBackups / https-finder

Automatically exported from code.google.com/p/https-finder
0 stars 0 forks source link

Creating a rule with the same name as an existing one overwrites it unadvertedly #43

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create a rule with the same name as existing one but for other domain, for 
example, in the case both share second level domain with different top level 
domain.
2. After restart (for HTTPS Everywhere to apply the new rule), the domain of 
the overwritten rule now triggers HTTPS Finder alerts.

What is the expected output? What do you see instead?
There should be an alert dialog to avoid overwrite rules with the same name 
unadvertedly, and to be able to choose another name for the new rule.

What version of the product are you using? On what operating system?
HTTPS Finder 0.79 on FF 11.0a1 (nightly) x32 on W7x64

Please provide any additional information below.
I found this signing out from gmail on a country not US nor India... when I 
sign out google connects to the google local domain and its facilities in 
India. Adding the rules, HTTPS Finder propose the same name for both rules, not 
alerting on overwriting, and after restarting HTTPS Finder alerts again to add 
a rule for the domain of the overwritten rule... and starts the loop again 
unless you use another rule name. 

Original issue reported on code.google.com by strel...@gmail.com on 6 Dec 2011 at 11:07

GoogleCodeExporter commented 9 years ago
Also, HTTPS Finder could propose rule names including second and top level 
domains to avoid confussion, in addition to the alert.

Original comment by strel...@gmail.com on 6 Dec 2011 at 11:34

GoogleCodeExporter commented 9 years ago
Thanks for the bug report. I've made a change to include the TLD in rule 
titles/file names. 

You can try the updated version here: 
https://code.google.com/p/https-finder/downloads/detail?name=httpsfinder080d1.xp
i

Let me know if you still have problems with it.

Original comment by jacobsK...@gmail.com on 8 Dec 2011 at 1:13

GoogleCodeExporter commented 9 years ago
But if for some reason someone is editing rules names before saving, and uses 
an existent name, the problem will arise again. The TLD serves as a workaround 
for the most of us, but is not a perfect solution.
Anyway that solves it for me. Thanks.

Original comment by strel...@gmail.com on 8 Dec 2011 at 1:37

GoogleCodeExporter commented 9 years ago
That's true - I'll add in a confirmation dialog requiring Yes/No response 
before overwriting into the next version.

thanks

Original comment by jacobsK...@gmail.com on 8 Dec 2011 at 1:47