YF-GoogleCodeBackups / https-finder

Automatically exported from code.google.com/p/https-finder
0 stars 0 forks source link

If some HTTPS Everywhere rule is deactivated, HTTPS Finder will issue an alert to add a rule for that site. #44

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Disable a rule for some site(s) in HTTPS Every options or thought its 
status/addon bar button.
2. Go to a site matching that rule through HTTP, and HTTPS Finder will offer to 
add a rule for that site, even a rule for that site already exists, but 
disabled.
3. The same happens if HTTPS Everywhere itself is disabled through menu option, 
i.e. not disabling the extension in the Addons Manager, but only its function.

What is the expected output? What do you see instead?
I understand HTTPS Finder checks whether HTTP sites have or not an HTTPS 
version, and triggers an alert to allow adding a rule for that site if 
affirmative. So to avoid the issue I think HTTPS Finder should implement a 
mechanism that, in case it finds an HTTPS version for an HTTP site, would 
evaluate its domain name against HTTPS-Everywhere installed rules... maybe 
taking the code to do that from HTTPS-Everywhere. In case it finds an existent 
rule for that site, HTTPS Finder could not trigger the alert or maybe it would 
trigger an alert for the user to be aware that the rule is disabled, which is 
something HTTPS Everywhere don't do, the user have to check its options or the 
status/addon bar button.

What version of the product are you using? On what operating system?
HTTP Finder 0.80d2 on FF 11.0a1 x32 on W7x64

Original issue reported on code.google.com by strel...@gmail.com on 8 Dec 2011 at 5:44

GoogleCodeExporter commented 8 years ago
When I suggested to trigger an alert to show some rule is disabled, I meant 
only in case HTTPS Everywhere is enabled, otherwise should not trigger any 
alert given that the rule exists, but HTTPS Everywhere is disabled.

Original comment by strel...@gmail.com on 8 Dec 2011 at 5:59

GoogleCodeExporter commented 8 years ago
This is something I hadn't added in yet, but it's certainly possible. HTTPS 
Everywhere rules are enabled and disabled with a bool preference (e.g. 
extensions.https_everywhere.google - true/false), so we could check that before 
saving a rule very easily.

I'll work on something for this over the next few weeks. Thanks

Original comment by jacobsK...@gmail.com on 9 Dec 2011 at 7:24

GoogleCodeExporter commented 8 years ago
I understand that each boolean covers 1 rules file, but each one can have 
multiple rules, and each rule can be a regular expression... so that makes 
things more complex to avoid effectively to add an overlapping rule.

Original comment by strel...@gmail.com on 9 Dec 2011 at 3:21

GoogleCodeExporter commented 8 years ago
That's very true. On the other hand, from what I've seen within HTTPS 
Everywhere, moving the actual rule list functionality over would be more akin 
to merging HTTPS Finder into HTTPS Everywhere, rather than just adding 
functionality to HTTPS Finder (i.e., it's a non-trivial problem). Also, since a 
lot of HTTPS Everywhere code came from NoScript, I feel like merging it into 
HTTPS Finder as well just adds a lot of overly-complicated code that's more 
'duct taped' together than anything.

I'll probably make a new branch of HTTPS Finder for this, and try to find a 
good solution over time.

Original comment by jacobsK...@gmail.com on 9 Dec 2011 at 5:34